From: Stefano Brivio <sbrivio@redhat.com>
To: Briana Oursler <briana.oursler@gmail.com>
Cc: gregkh@linuxfoundation.org, julia.lawall@inria.fr,
forest@alittletooquiet.net, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [Patch v4 0/4] Staging: vt6655: Remove unused functions.
Date: Fri, 3 Apr 2020 02:03:35 +0200 [thread overview]
Message-ID: <20200403020335.0bc916ab@elisabeth> (raw)
In-Reply-To: <cover.1585802818.git.briana.oursler@gmail.com>
On Wed, 1 Apr 2020 22:14:32 -0700
Briana Oursler <briana.oursler@gmail.com> wrote:
> This patchset removes functions that are not called in the driver but
> are prototyped in card.h. Each commit limits its scope to one function
> definition and related documentation in code.
>
> Functions were checked for calls using the Elixir Cross Referencer and
> git grep.
>
> Per Stefano Brivio's recommendation, output of bloatometer script after
> changes:
>
> add/remove: 0/4 grow/shrink: 0/0 up/down: 0/-572 (-572)
> Function old new delta
> CARDbSoftwareReset 10 - -10
> CARDvSetLoopbackMode 14 - -14
> BBvExitDeepSleep 40 - -40
> CARDbRadioPowerOn 508 - -508
> Total: Before=36131, After=35559, chg -1.58%
>
> Briana Oursler (4):
> Staging: vt6655: Remove CARDbSoftwareReset definition.
> Staging: vt6655: Remove CARDvSetLoopbackMode definition.
> Staging: vt6655: Remove CARDbRadioPowerOn definition.
> Staging: vt6655: Remove BBvExitDeepSleep definition.
For the series,
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2020-04-03 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 5:14 [Patch v4 0/4] Staging: vt6655: Remove unused functions Briana Oursler
2020-04-02 5:14 ` [Patch v4 1/4] Staging: vt6655: Remove CARDbSoftwareReset definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 2/4] Staging: vt6655: Remove CARDvSetLoopbackMode definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 3/4] Staging: vt6655: Remove CARDbRadioPowerOn definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 4/4] Staging: vt6655: Remove BBvExitDeepSleep definition Briana Oursler
2020-04-03 0:03 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403020335.0bc916ab@elisabeth \
--to=sbrivio@redhat.com \
--cc=briana.oursler@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.