From: Briana Oursler <briana.oursler@gmail.com>
To: sbrivio@redhat.com, gregkh@linuxfoundation.org,
julia.lawall@inria.fr, forest@alittletooquiet.net,
outreachy-kernel@googlegroups.com
Cc: Briana Oursler <briana.oursler@gmail.com>
Subject: [Patch v4 0/4] Staging: vt6655: Remove unused functions.
Date: Wed, 1 Apr 2020 22:14:32 -0700 [thread overview]
Message-ID: <cover.1585802818.git.briana.oursler@gmail.com> (raw)
This patchset removes functions that are not called in the driver but
are prototyped in card.h. Each commit limits its scope to one function
definition and related documentation in code.
Functions were checked for calls using the Elixir Cross Referencer and
git grep.
Per Stefano Brivio's recommendation, output of bloatometer script after
changes:
add/remove: 0/4 grow/shrink: 0/0 up/down: 0/-572 (-572)
Function old new delta
CARDbSoftwareReset 10 - -10
CARDvSetLoopbackMode 14 - -14
BBvExitDeepSleep 40 - -40
CARDbRadioPowerOn 508 - -508
Total: Before=36131, After=35559, chg -1.58%
Briana Oursler (4):
Staging: vt6655: Remove CARDbSoftwareReset definition.
Staging: vt6655: Remove CARDvSetLoopbackMode definition.
Staging: vt6655: Remove CARDbRadioPowerOn definition.
Staging: vt6655: Remove BBvExitDeepSleep definition.
Changes in v4:
- Update patch series title.
- Add patch 4/4 per suggestion of Julia Lawall.
- Patches 1/4-3/4 unchanged.
Changes in v3:
- Update language in patch series name at suggestions from
Stefano Brivio and Julia Lawall.
- Remove references to the changelog in the cover letter. It is
unrelated to this series.
Changes in v2:
- Add output of bloatometer.
- Change language from "uncalled function" to "function...that
is never called" in each patch description within the series.
drivers/staging/vt6655/baseband.c | 6 --
drivers/staging/vt6655/baseband.h | 1 -
drivers/staging/vt6655/card.c | 105 ------------------------------
drivers/staging/vt6655/card.h | 4 --
4 files changed, 116 deletions(-)
--
2.24.1
next reply other threads:[~2020-04-02 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 5:14 Briana Oursler [this message]
2020-04-02 5:14 ` [Patch v4 1/4] Staging: vt6655: Remove CARDbSoftwareReset definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 2/4] Staging: vt6655: Remove CARDvSetLoopbackMode definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 3/4] Staging: vt6655: Remove CARDbRadioPowerOn definition Briana Oursler
2020-04-02 5:14 ` [Patch v4 4/4] Staging: vt6655: Remove BBvExitDeepSleep definition Briana Oursler
2020-04-03 0:03 ` [Outreachy kernel] [Patch v4 0/4] Staging: vt6655: Remove unused functions Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1585802818.git.briana.oursler@gmail.com \
--to=briana.oursler@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.