From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Hyunki Koo <hyunki00.koo@samsung.com>,
Kukjin Kim <kgene@kernel.org>, Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers
Date: Fri, 3 Apr 2020 14:08:28 +0200 [thread overview]
Message-ID: <20200403120828.GA30617@kozik-lap> (raw)
In-Reply-To: <20200403115715.GA3846995@kroah.com>
On Fri, Apr 03, 2020 at 01:57:15PM +0200, Greg KH wrote:
> > > If the property is not there, the type will be uninitialized and no
> > > warning will be spit out, are you sure you want to do that?
> >
> > The default value from initial ourport will be used, which is UPIO_MEM.
> > This way it is backward compatible.
>
> Where is iotype set to UPIO_MEM as a default?
Here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/samsung_tty.c?h=v5.6#n1626
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/samsung_tty.c?h=v5.6#n1989
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
Hyunki Koo <hyunki00.koo@samsung.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] tty: samsung_tty: 32-bit access for TX/RX hold registers
Date: Fri, 3 Apr 2020 14:08:28 +0200 [thread overview]
Message-ID: <20200403120828.GA30617@kozik-lap> (raw)
In-Reply-To: <20200403115715.GA3846995@kroah.com>
On Fri, Apr 03, 2020 at 01:57:15PM +0200, Greg KH wrote:
> > > If the property is not there, the type will be uninitialized and no
> > > warning will be spit out, are you sure you want to do that?
> >
> > The default value from initial ourport will be used, which is UPIO_MEM.
> > This way it is backward compatible.
>
> Where is iotype set to UPIO_MEM as a default?
Here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/samsung_tty.c?h=v5.6#n1626
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/samsung_tty.c?h=v5.6#n1989
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-03 12:08 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200401082749epcas2p2a774da515805bc3f761b6b5a8dc9e3d2@epcas2p2.samsung.com>
2020-04-01 8:27 ` [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Hyunki Koo
2020-04-01 8:27 ` Hyunki Koo
2020-04-01 8:55 ` Greg Kroah-Hartman
2020-04-01 8:55 ` Greg Kroah-Hartman
2020-04-01 9:19 ` Krzysztof Kozlowski
2020-04-01 9:19 ` Krzysztof Kozlowski
2020-04-02 9:44 ` Hyunki Koo
2020-04-02 9:44 ` Hyunki Koo
2020-04-02 9:48 ` 'Krzysztof Kozlowski'
2020-04-02 9:48 ` 'Krzysztof Kozlowski'
2020-04-02 11:04 ` [PATCH v2] " Hyunki Koo
2020-04-02 11:04 ` Hyunki Koo
2020-04-02 12:18 ` Greg KH
2020-04-02 12:18 ` Greg KH
2020-04-02 13:59 ` Krzysztof Kozlowski
2020-04-02 13:59 ` Krzysztof Kozlowski
2020-04-03 7:30 ` Hyunki Koo
2020-04-03 7:30 ` Hyunki Koo
2020-04-03 7:51 ` 'Krzysztof Kozlowski'
2020-04-03 7:51 ` 'Krzysztof Kozlowski'
2020-04-03 10:19 ` Hyunki Koo
2020-04-03 10:19 ` Hyunki Koo
2020-04-03 10:20 ` [PATCH v3] " Hyunki Koo
2020-04-03 10:20 ` Hyunki Koo
2020-04-03 10:47 ` Krzysztof Kozlowski
2020-04-03 10:47 ` Krzysztof Kozlowski
2020-04-03 11:12 ` Hyunki Koo
2020-04-03 11:12 ` Hyunki Koo
2020-04-03 11:39 ` 'Krzysztof Kozlowski'
2020-04-03 11:39 ` 'Krzysztof Kozlowski'
2020-04-03 11:15 ` [PATCH v4] " Hyunki Koo
2020-04-03 11:15 ` Hyunki Koo
2020-04-03 11:42 ` Greg KH
2020-04-03 11:42 ` Greg KH
2020-04-03 11:53 ` Krzysztof Kozlowski
2020-04-03 11:53 ` Krzysztof Kozlowski
2020-04-03 11:57 ` Greg KH
2020-04-03 11:57 ` Greg KH
2020-04-03 12:08 ` Krzysztof Kozlowski [this message]
2020-04-03 12:08 ` Krzysztof Kozlowski
2020-04-03 11:59 ` Krzysztof Kozlowski
2020-04-03 11:59 ` Krzysztof Kozlowski
2020-04-05 21:35 ` Hyunki Koo
2020-04-05 21:35 ` Hyunki Koo
2020-04-06 9:54 ` 'Krzysztof Kozlowski'
2020-04-06 9:54 ` 'Krzysztof Kozlowski'
2020-04-03 13:34 ` Krzysztof Kozlowski
2020-04-03 13:34 ` Krzysztof Kozlowski
2020-04-05 21:41 ` Hyunki Koo
2020-04-05 21:41 ` Hyunki Koo
2020-04-06 9:53 ` 'Krzysztof Kozlowski'
2020-04-06 9:53 ` 'Krzysztof Kozlowski'
2020-04-06 10:31 ` [PATCH v5 2/2] " Hyunki Koo
2020-04-06 10:31 ` Hyunki Koo
2020-04-06 10:31 ` [PATCH v5 1/2] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-06 10:47 ` Krzysztof Kozlowski
2020-04-06 10:34 ` [PATCH v5 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Krzysztof Kozlowski
2020-04-06 10:34 ` Krzysztof Kozlowski
2020-04-06 23:08 ` [PATCH v6 " Hyunki Koo
2020-04-06 23:08 ` Hyunki Koo
2020-04-06 23:08 ` [PATCH v6 1/2] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-07 6:25 ` Krzysztof Kozlowski
2020-04-09 23:05 ` Rob Herring
2020-04-09 23:09 ` Rob Herring
2020-04-07 4:49 ` [PATCH v6 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Jiri Slaby
2020-04-07 4:49 ` Jiri Slaby
2020-04-07 6:02 ` Hyunki Koo
2020-04-07 6:02 ` Hyunki Koo
2020-04-07 6:24 ` Krzysztof Kozlowski
2020-04-07 6:24 ` Krzysztof Kozlowski
2020-04-07 6:32 ` Jiri Slaby
2020-04-07 6:32 ` Jiri Slaby
2020-04-07 7:22 ` Krzysztof Kozlowski
2020-04-07 7:22 ` Krzysztof Kozlowski
2020-04-07 6:26 ` Krzysztof Kozlowski
2020-04-07 6:26 ` Krzysztof Kozlowski
2020-04-07 6:28 ` Jiri Slaby
2020-04-07 6:28 ` Jiri Slaby
2020-04-07 6:37 ` Jiri Slaby
2020-04-07 6:37 ` Jiri Slaby
2020-04-07 6:54 ` Hyunki Koo
2020-04-07 6:54 ` Hyunki Koo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403120828.GA30617@kozik-lap \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hyunki00.koo@samsung.com \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.