Re: [poky] [PATCH] sanity.bbclass: echo current SDK_VENDOR if it is invalid

["Denys Dmytriyenko" <denis@denix.org>]

Why Poky? Should this go to OE-Core?

On Fri, Apr 03, 2020 at 11:31:51AM -0400, Paul Gortmaker wrote:
> It can be frustrating if this sanity check triggers, but you
> don't know why; you haven't explicitly set any SDK vars, or
> similar.
> 
> At least echo out the offending value, so the end user has
> a bit more information to go on.
> 
> Before:
>   SDK_VENDOR should be of the form '-foosdk' with a single dash
> After:
>   SDK_VENDOR should be of the form '-foosdk' with a single dash; found '-overc-sdk'
> 
> Cc: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 88888e814a48..c823b49c03b0 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -823,7 +823,7 @@ def check_sanity_everybuild(status, d):
>      # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early
>      sdkvendor = d.getVar("SDK_VENDOR")
>      if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1):
> -        status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n")
> +        status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash; found '%s'\n" % sdkvendor)
>  
>      check_supported_distro(d)
>  
> -- 
> 2.17.1
> 

>