From: "Paul Gortmaker" <paul.gortmaker@windriver.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: <poky@lists.yoctoproject.org>, Ross Burton <ross.burton@intel.com>
Subject: Re: [poky] [PATCH] sanity.bbclass: echo current SDK_VENDOR if it is invalid
Date: Fri, 3 Apr 2020 12:25:21 -0400 [thread overview]
Message-ID: <20200403162520.GP6244@windriver.com> (raw)
In-Reply-To: <20200403154402.GV1578@denix.org>
[Re: [poky] [PATCH] sanity.bbclass: echo current SDK_VENDOR if it is invalid] On 03/04/2020 (Fri 11:44) Denys Dmytriyenko wrote:
> Why Poky? Should this go to OE-Core?
Probably. Maybe after another 10y with yocto/oe-core/poky I'll finally
manage to get the right mailing lists for the right components...?
Anyway, thanks - resent to oe-core.
Paul.
--
>
> On Fri, Apr 03, 2020 at 11:31:51AM -0400, Paul Gortmaker wrote:
> > It can be frustrating if this sanity check triggers, but you
> > don't know why; you haven't explicitly set any SDK vars, or
> > similar.
> >
> > At least echo out the offending value, so the end user has
> > a bit more information to go on.
> >
> > Before:
> > SDK_VENDOR should be of the form '-foosdk' with a single dash
> > After:
> > SDK_VENDOR should be of the form '-foosdk' with a single dash; found '-overc-sdk'
> >
> > Cc: Ross Burton <ross.burton@intel.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > index 88888e814a48..c823b49c03b0 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -823,7 +823,7 @@ def check_sanity_everybuild(status, d):
> > # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early
> > sdkvendor = d.getVar("SDK_VENDOR")
> > if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1):
> > - status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n")
> > + status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash; found '%s'\n" % sdkvendor)
> >
> > check_supported_distro(d)
> >
> > --
> > 2.17.1
> >
>
> >
>
prev parent reply other threads:[~2020-04-03 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 15:31 [PATCH] sanity.bbclass: echo current SDK_VENDOR if it is invalid Paul Gortmaker
2020-04-03 15:44 ` [poky] " Denys Dmytriyenko
2020-04-03 16:25 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403162520.GP6244@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=denis@denix.org \
--cc=poky@lists.yoctoproject.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.