* [PATCH -next] pwm: make pwm_apply_state_debug static
@ 2020-04-02 6:57 Jason Yan
2020-04-02 14:10 ` Uwe Kleine-König
2020-04-03 19:43 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-02 6:57 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm; +Cc: Jason Yan
Fix the following gcc warning:
drivers/pwm/core.c:467:6: warning: symbol 'pwm_apply_state_debug' was
not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/pwm/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index e9b9283cff28..9973c442b455 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -464,8 +464,8 @@ void pwm_free(struct pwm_device *pwm)
}
EXPORT_SYMBOL_GPL(pwm_free);
-void pwm_apply_state_debug(struct pwm_device *pwm,
- const struct pwm_state *state)
+static void pwm_apply_state_debug(struct pwm_device *pwm,
+ const struct pwm_state *state)
{
struct pwm_state *last = &pwm->last;
struct pwm_chip *chip = pwm->chip;
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] pwm: make pwm_apply_state_debug static
2020-04-02 6:57 [PATCH -next] pwm: make pwm_apply_state_debug static Jason Yan
@ 2020-04-02 14:10 ` Uwe Kleine-König
2020-04-03 19:43 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-04-02 14:10 UTC (permalink / raw)
To: Jason Yan; +Cc: thierry.reding, linux-pwm
On Thu, Apr 02, 2020 at 02:57:18PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/pwm/core.c:467:6: warning: symbol 'pwm_apply_state_debug' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Looks sensible:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers")
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] pwm: make pwm_apply_state_debug static
2020-04-02 6:57 [PATCH -next] pwm: make pwm_apply_state_debug static Jason Yan
2020-04-02 14:10 ` Uwe Kleine-König
@ 2020-04-03 19:43 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2020-04-03 19:43 UTC (permalink / raw)
To: Jason Yan; +Cc: u.kleine-koenig, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Thu, Apr 02, 2020 at 02:57:18PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/pwm/core.c:467:6: warning: symbol 'pwm_apply_state_debug' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/pwm/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-03 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02 6:57 [PATCH -next] pwm: make pwm_apply_state_debug static Jason Yan
2020-04-02 14:10 ` Uwe Kleine-König
2020-04-03 19:43 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.