From: Thierry Reding <thierry.reding@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-pwm@vger.kernel.org, "Kevin Hilman" <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: meson: remove redundant assignment to variable fin_freq
Date: Fri, 03 Apr 2020 19:43:55 +0000 [thread overview]
Message-ID: <20200403194355.GB201060@ulmo> (raw)
In-Reply-To: <20200402110857.509844-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable fin_freq is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pwm/pwm-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-pwm@vger.kernel.org, "Kevin Hilman" <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: meson: remove redundant assignment to variable fin_freq
Date: Fri, 3 Apr 2020 21:43:55 +0200 [thread overview]
Message-ID: <20200403194355.GB201060@ulmo> (raw)
In-Reply-To: <20200402110857.509844-1-colin.king@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable fin_freq is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pwm/pwm-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Kevin Hilman" <khilman@baylibre.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: meson: remove redundant assignment to variable fin_freq
Date: Fri, 3 Apr 2020 21:43:55 +0200 [thread overview]
Message-ID: <20200403194355.GB201060@ulmo> (raw)
In-Reply-To: <20200402110857.509844-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable fin_freq is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pwm/pwm-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-pwm@vger.kernel.org, "Kevin Hilman" <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: meson: remove redundant assignment to variable fin_freq
Date: Fri, 3 Apr 2020 21:43:55 +0200 [thread overview]
Message-ID: <20200403194355.GB201060@ulmo> (raw)
In-Reply-To: <20200402110857.509844-1-colin.king@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable fin_freq is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pwm/pwm-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-03 19:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:08 [PATCH] pwm: meson: remove redundant assignment to variable fin_freq Colin King
2020-04-02 11:08 ` Colin King
2020-04-02 11:08 ` Colin King
2020-04-02 11:08 ` Colin King
2020-04-02 14:15 ` Uwe Kleine-König
2020-04-02 14:15 ` Uwe Kleine-König
2020-04-02 14:15 ` Uwe Kleine-König
2020-04-02 14:15 ` Uwe Kleine-König
2020-04-03 19:43 ` Thierry Reding [this message]
2020-04-03 19:43 ` Thierry Reding
2020-04-03 19:43 ` Thierry Reding
2020-04-03 19:43 ` Thierry Reding
2020-04-16 16:08 ` patchwork-bot+linux-amlogic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403194355.GB201060@ulmo \
--to=thierry.reding@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.