* [Buildroot] [PATCH v1] package/libnss: fix compile failure
@ 2020-04-03 19:45 Peter Seiderer
2020-04-03 20:00 ` Giulio Benetti
0 siblings, 1 reply; 7+ messages in thread
From: Peter Seiderer @ 2020-04-03 19:45 UTC (permalink / raw)
To: buildroot
Add upstream patch to fix neon related compile failure
(tested with rpi3 configuration).
Fixes:
http://autobuild.buildroot.net/results/ebfa6bfabfe98fddbc1590c4d5d8038f3eb8992c
http://autobuild.buildroot.net/results/7626a9f4d604b3657b88a4a6da4db3a8eb810059
http://autobuild.buildroot.net/results/2625066922fb83db42ad4ddbc26bdf0b3ef09cb1
http://autobuild.buildroot.net/results/c4b3a4a6d39773c2faa8595f64f1ce747971f5a0
.../host/bin/arm-linux-gnueabihf-gcc -o Linux2.6_arm_arm-linux-gnueabihf-gcc_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/gcm-arm32-neon.o -c -std=c99 -g -fPIC -pipe -ffunction-sections -fdata-sections -DHAVE_STRERROR -DLINUX -Dlinux -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -Wshadow -DNSS_NO_GCC48 -DXP_UNIX -DSHLIB_SUFFIX=\"so\" -DSHLIB_PREFIX=\"lib\" -DSHLIB_VERSION=\"3\" -DSOFTOKEN_SHLIB_VERSION=\"3\" -DRIJNDAEL_INCLUDE_TABLES -DDEBUG -UNDEBUG -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -D_REENTRANT -DNSS_NO_INIT_SUPPORT -DNSS_DISABLE_ALTIVEC -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DFREEBL_NO_DEPEND -DFREEBL_LOWHASH -DUSE_HW_AES -DMP_ASSEMBLY_MULTIPLY -DMP_ASSEMBLY_SQUARE -DMP_USE_UINT_DIGIT -DSHA_NO_LONG_LONG -DKRML_VERIFIED_UINT128 -DMP_API_COMPATIBLE -I.../host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/nspr -I.../build/libnss-3.51/dist/include -I../../../dist/public/nss -I../../../dist/private/nss -Impi -Iecl -Iverified -Iverified/kremlin/include -Iverified/kremlin/kremlib/dist/minimal -march=armv7 -mfpu=neon gcm-arm32-neon.c
cc1: error: target CPU does not support ARM mode
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
diff --git a/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
new file mode 100644
index 0000000000..64cc18c8c3
--- /dev/null
+++ b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
@@ -0,0 +1,30 @@
+From 63d548663871e0157a4513a661b4a721002192e6 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Wed, 1 Apr 2020 09:41:08 -0700
+Subject: [PATCH] Bug 1624864 - Don't force ARMv7 for gcm-arm32-neon r=jcj
+
+--HG--
+extra : rebase_source : e046bbe45276b8cdf686c4f61006aff08865f1c0
+
+[Upstream: https://github.com/nss-dev/nss/commit/ab8d2425728f37b1f21dbff712daf4a767c82149]
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ nss/lib/freebl/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/nss/lib/freebl/Makefile b/nss/lib/freebl/Makefile
+index 2802fdf..eedebd3 100644
+--- a/nss/lib/freebl/Makefile
++++ b/nss/lib/freebl/Makefile
+@@ -773,7 +773,7 @@ ifeq ($(CPU_ARCH),arm)
+ USES_SOFTFLOAT_ABI := $(shell $(CC) -o - -E -dM - $(CFLAGS) < /dev/null | grep __SOFTFP__ > /dev/null && echo 1)
+ $(OBJDIR)/$(PROG_PREFIX)aes-armv8$(OBJ_SUFFIX): CFLAGS += -march=armv8-a -mfpu=crypto-neon-fp-armv8$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
+ ifndef NSS_DISABLE_GCM_ARM32_NEON
+-$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -march=armv7 -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
++$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
+ endif
+ endif
+ ifeq ($(CPU_ARCH),aarch64)
+--
+2.26.0
+
--
2.26.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1] package/libnss: fix compile failure
2020-04-03 19:45 [Buildroot] [PATCH v1] package/libnss: fix compile failure Peter Seiderer
@ 2020-04-03 20:00 ` Giulio Benetti
2020-04-03 20:10 ` [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7 Giulio Benetti
2020-04-03 21:01 ` [Buildroot] [PATCH v1] package/libnss: fix compile failure Peter Seiderer
0 siblings, 2 replies; 7+ messages in thread
From: Giulio Benetti @ 2020-04-03 20:00 UTC (permalink / raw)
To: buildroot
Hi Peter,
I've already sent a patch for this but I need to re-word and re-send it:
https://patchwork.ozlabs.org/patch/1261416/
Best regards
--
Giulio Benetti
Benetti Engineering sas
On 4/3/20 9:45 PM, Peter Seiderer wrote:
> Add upstream patch to fix neon related compile failure
> (tested with rpi3 configuration).
>
> Fixes:
> http://autobuild.buildroot.net/results/ebfa6bfabfe98fddbc1590c4d5d8038f3eb8992c
> http://autobuild.buildroot.net/results/7626a9f4d604b3657b88a4a6da4db3a8eb810059
> http://autobuild.buildroot.net/results/2625066922fb83db42ad4ddbc26bdf0b3ef09cb1
> http://autobuild.buildroot.net/results/c4b3a4a6d39773c2faa8595f64f1ce747971f5a0
>
> .../host/bin/arm-linux-gnueabihf-gcc -o Linux2.6_arm_arm-linux-gnueabihf-gcc_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/gcm-arm32-neon.o -c -std=c99 -g -fPIC -pipe -ffunction-sections -fdata-sections -DHAVE_STRERROR -DLINUX -Dlinux -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wall -Wshadow -DNSS_NO_GCC48 -DXP_UNIX -DSHLIB_SUFFIX=\"so\" -DSHLIB_PREFIX=\"lib\" -DSHLIB_VERSION=\"3\" -DSOFTOKEN_SHLIB_VERSION=\"3\" -DRIJNDAEL_INCLUDE_TABLES -DDEBUG -UNDEBUG -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -D_REENTRANT -DNSS_NO_INIT_SUPPORT -DNSS_DISABLE_ALTIVEC -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DFREEBL_NO_DEPEND -DFREEBL_LOWHASH -DUSE_HW_AES -DMP_ASSEMBLY_MULTIPLY -DMP_ASSEMBLY_SQUARE -DMP_USE_UINT_DIGIT -DSHA_NO_LONG_LONG -DKRML_VERIFIED_UINT128 -DMP_API_COMPATIBLE -I.../host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/nspr -I.../build/libnss-3.51/dist/include -I../../../dist/public/nss -I../../.
> ./dist/private/nss -Impi -Iecl -Iverified -Iverified/kremlin/include -Iverified/kremlin/kremlib/dist/minimal -march=armv7 -mfpu=neon gcm-arm32-neon.c
> cc1: error: target CPU does not support ARM mode
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
>
> diff --git a/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
> new file mode 100644
> index 0000000000..64cc18c8c3
> --- /dev/null
> +++ b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
> @@ -0,0 +1,30 @@
> +From 63d548663871e0157a4513a661b4a721002192e6 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Wed, 1 Apr 2020 09:41:08 -0700
> +Subject: [PATCH] Bug 1624864 - Don't force ARMv7 for gcm-arm32-neon r=jcj
> +
> +--HG--
> +extra : rebase_source : e046bbe45276b8cdf686c4f61006aff08865f1c0
> +
> +[Upstream: https://github.com/nss-dev/nss/commit/ab8d2425728f37b1f21dbff712daf4a767c82149]
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + nss/lib/freebl/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/nss/lib/freebl/Makefile b/nss/lib/freebl/Makefile
> +index 2802fdf..eedebd3 100644
> +--- a/nss/lib/freebl/Makefile
> ++++ b/nss/lib/freebl/Makefile
> +@@ -773,7 +773,7 @@ ifeq ($(CPU_ARCH),arm)
> + USES_SOFTFLOAT_ABI := $(shell $(CC) -o - -E -dM - $(CFLAGS) < /dev/null | grep __SOFTFP__ > /dev/null && echo 1)
> + $(OBJDIR)/$(PROG_PREFIX)aes-armv8$(OBJ_SUFFIX): CFLAGS += -march=armv8-a -mfpu=crypto-neon-fp-armv8$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> + ifndef NSS_DISABLE_GCM_ARM32_NEON
> +-$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -march=armv7 -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> ++$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> + endif
> + endif
> + ifeq ($(CPU_ARCH),aarch64)
> +--
> +2.26.0
> +
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7
2020-04-03 20:00 ` Giulio Benetti
@ 2020-04-03 20:10 ` Giulio Benetti
2020-04-03 21:06 ` Peter Seiderer
2020-04-04 20:58 ` Thomas Petazzoni
2020-04-03 21:01 ` [Buildroot] [PATCH v1] package/libnss: fix compile failure Peter Seiderer
1 sibling, 2 replies; 7+ messages in thread
From: Giulio Benetti @ 2020-04-03 20:10 UTC (permalink / raw)
To: buildroot
NSS assumes that every neon arm32 build is an armv7, but this is
not always true(i.e. build arm32 for armv8), so let's add a patch to
remove -march=armv7 flag when building gcm-arm32-neon.c
Fixes:
http://autobuild.buildroot.net/results/464/464044fda2850123339de6c8071374e380636ee0/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* update with upstreamed patch:
https://bugzilla.mozilla.org/show_bug.cgi?id=1624864
* improve commit log
---
...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
diff --git a/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
new file mode 100644
index 0000000000..eae1ed974c
--- /dev/null
+++ b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
@@ -0,0 +1,29 @@
+From ab8d2425728f37b1f21dbff712daf4a767c82149 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Wed, 1 Apr 2020 09:41:08 -0700
+Subject: [PATCH] Bug 1624864 - Don't force ARMv7 for gcm-arm32-neon r=jcj
+
+--HG--
+extra : rebase_source : e046bbe45276b8cdf686c4f61006aff08865f1c0
+
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ nss/lib/freebl/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/nss/lib/freebl/Makefile b/nss/lib/freebl/Makefile
+index a03c0d108..898a0b9e0 100644
+--- a/nss/lib/freebl/Makefile
++++ b/nss/lib/freebl/Makefile
+@@ -781,7 +781,7 @@ ifeq ($(CPU_ARCH),arm)
+ USES_SOFTFLOAT_ABI := $(shell $(CC) -o - -E -dM - $(CFLAGS) < /dev/null | grep __SOFTFP__ > /dev/null && echo 1)
+ $(OBJDIR)/$(PROG_PREFIX)aes-armv8$(OBJ_SUFFIX): CFLAGS += -march=armv8-a -mfpu=crypto-neon-fp-armv8$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
+ ifndef NSS_DISABLE_ARM32_NEON
+-$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -march=armv7 -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
++$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
+ endif
+ endif
+ ifeq ($(CPU_ARCH),aarch64)
+--
+2.20.1
+
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7
2020-04-03 20:10 ` [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7 Giulio Benetti
@ 2020-04-03 21:06 ` Peter Seiderer
2020-04-04 20:58 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Peter Seiderer @ 2020-04-03 21:06 UTC (permalink / raw)
To: buildroot
Hello Giulio,
On Fri, 3 Apr 2020 22:10:21 +0200, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> NSS assumes that every neon arm32 build is an armv7, but this is
> not always true(i.e. build arm32 for armv8), so let's add a patch to
> remove -march=armv7 flag when building gcm-arm32-neon.c
>
> Fixes:
> http://autobuild.buildroot.net/results/464/464044fda2850123339de6c8071374e380636ee0/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * update with upstreamed patch:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1624864
This two lines are worth mentioning in the commit message...
> * improve commit log
> ---
> ...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
>
> diff --git a/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
> new file mode 100644
> index 0000000000..eae1ed974c
> --- /dev/null
> +++ b/package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
> @@ -0,0 +1,29 @@
> +From ab8d2425728f37b1f21dbff712daf4a767c82149 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Wed, 1 Apr 2020 09:41:08 -0700
> +Subject: [PATCH] Bug 1624864 - Don't force ARMv7 for gcm-arm32-neon r=jcj
> +
> +--HG--
> +extra : rebase_source : e046bbe45276b8cdf686c4f61006aff08865f1c0
> +
Please add the upstream source link here, e.g. (or and/or the bug report link):
[Upstream: https://hg.mozilla.org/projects/nss/rev/8582092359720d052288cad2dc13f37aad783dc3]
With the two changes you can add my
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + nss/lib/freebl/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/nss/lib/freebl/Makefile b/nss/lib/freebl/Makefile
> +index a03c0d108..898a0b9e0 100644
> +--- a/nss/lib/freebl/Makefile
> ++++ b/nss/lib/freebl/Makefile
> +@@ -781,7 +781,7 @@ ifeq ($(CPU_ARCH),arm)
> + USES_SOFTFLOAT_ABI := $(shell $(CC) -o - -E -dM - $(CFLAGS) < /dev/null | grep __SOFTFP__ > /dev/null && echo 1)
> + $(OBJDIR)/$(PROG_PREFIX)aes-armv8$(OBJ_SUFFIX): CFLAGS += -march=armv8-a -mfpu=crypto-neon-fp-armv8$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> + ifndef NSS_DISABLE_ARM32_NEON
> +-$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -march=armv7 -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> ++$(OBJDIR)/$(PROG_PREFIX)gcm-arm32-neon$(OBJ_SUFFIX): CFLAGS += -mfpu=neon$(if $(USES_SOFTFLOAT_ABI), -mfloat-abi=softfp)
> + endif
> + endif
> + ifeq ($(CPU_ARCH),aarch64)
> +--
> +2.20.1
> +
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7
2020-04-03 20:10 ` [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7 Giulio Benetti
2020-04-03 21:06 ` Peter Seiderer
@ 2020-04-04 20:58 ` Thomas Petazzoni
2020-04-05 17:13 ` Giulio Benetti
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2020-04-04 20:58 UTC (permalink / raw)
To: buildroot
On Fri, 3 Apr 2020 22:10:21 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> NSS assumes that every neon arm32 build is an armv7, but this is
> not always true(i.e. build arm32 for armv8), so let's add a patch to
> remove -march=armv7 flag when building gcm-arm32-neon.c
>
> Fixes:
> http://autobuild.buildroot.net/results/464/464044fda2850123339de6c8071374e380636ee0/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * update with upstreamed patch:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1624864
> * improve commit log
> ---
> ...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
Applied to master with an updated reference to the upstream patch, as
suggested by Peter Seiderer.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7
2020-04-04 20:58 ` Thomas Petazzoni
@ 2020-04-05 17:13 ` Giulio Benetti
0 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2020-04-05 17:13 UTC (permalink / raw)
To: buildroot
On 4/4/20 10:58 PM, Thomas Petazzoni wrote:
> On Fri, 3 Apr 2020 22:10:21 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>
>> NSS assumes that every neon arm32 build is an armv7, but this is
>> not always true(i.e. build arm32 for armv8), so let's add a patch to
>> remove -march=armv7 flag when building gcm-arm32-neon.c
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/464/464044fda2850123339de6c8071374e380636ee0/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> V1->V2:
>> * update with upstreamed patch:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1624864
>> * improve commit log
>> ---
>> ...t-force-ARMv7-for-gcm-arm32-neon-r-j.patch | 29 +++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>> create mode 100644 package/libnss/0002-Bug-1624864-Don-t-force-ARMv7-for-gcm-arm32-neon-r-j.patch
>
> Applied to master with an updated reference to the upstream patch, as
> suggested by Peter Seiderer.
Thank you Thomas, unfortunately I didn't check very well and this makes
build to fail because 0002 can't be applied over patch 0001. So for this
I've sent another patch:
https://patchwork.ozlabs.org/patch/1266591/
Sorry for the noise
Best regards
--
Giulio Benetti
Benetti Engineering sas
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1] package/libnss: fix compile failure
2020-04-03 20:00 ` Giulio Benetti
2020-04-03 20:10 ` [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7 Giulio Benetti
@ 2020-04-03 21:01 ` Peter Seiderer
1 sibling, 0 replies; 7+ messages in thread
From: Peter Seiderer @ 2020-04-03 21:01 UTC (permalink / raw)
To: buildroot
Hello Giulio,
On Fri, 3 Apr 2020 22:00:07 +0200, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Hi Peter,
>
> I've already sent a patch for this but I need to re-word and re-send it:
> https://patchwork.ozlabs.org/patch/1261416/
Ups, missed your previous patch, sorry for the noise....
Regards,
Peter
>
> Best regards
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-05 17:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-03 19:45 [Buildroot] [PATCH v1] package/libnss: fix compile failure Peter Seiderer
2020-04-03 20:00 ` Giulio Benetti
2020-04-03 20:10 ` [Buildroot] [PATCH v2] package/libnss: fix build failure on arm32 arch not armv7 Giulio Benetti
2020-04-03 21:06 ` Peter Seiderer
2020-04-04 20:58 ` Thomas Petazzoni
2020-04-05 17:13 ` Giulio Benetti
2020-04-03 21:01 ` [Buildroot] [PATCH v1] package/libnss: fix compile failure Peter Seiderer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.