[bug report] iwlwifi: add mac/rf types and 160MHz to the device tables

[bug report] iwlwifi: add mac/rf types and 160MHz to the device tables

[Dan Carpenter]

Hello Luca Coelho,

The patch d6f2134a3831: "iwlwifi: add mac/rf types and 160MHz to the
device tables" from Mar 9, 2020, leads to the following static
checker warning:

	drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1007 iwl_pci_probe()
	warn: mask and shift to zero

drivers/net/wireless/intel/iwlwifi/pcie/drv.c
   989                  if ((dev_info->device == (u16)IWL_CFG_ANY ||
   990                       dev_info->device == pdev->device) &&
   991                      (dev_info->subdevice == (u16)IWL_CFG_ANY ||
   992                       dev_info->subdevice == pdev->subsystem_device) &&
   993                      (dev_info->mac_type == (u16)IWL_CFG_ANY ||
   994                       dev_info->mac_type ==
   995                       CSR_HW_REV_TYPE(iwl_trans->hw_rev)) &&
   996                      (dev_info->mac_step == (u8)IWL_CFG_ANY ||
   997                       dev_info->mac_step ==
   998                       CSR_HW_REV_STEP(iwl_trans->hw_rev)) &&
   999                      (dev_info->rf_type == (u16)IWL_CFG_ANY ||
  1000                       dev_info->rf_type ==
  1001                       CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id)) &&
  1002                      (dev_info->rf_id == (u8)IWL_CFG_ANY ||
  1003                       dev_info->rf_id ==
  1004                       IWL_SUBDEVICE_RF_ID(pdev->subsystem_device)) &&
  1005                      (dev_info->no_160 == (u8)IWL_CFG_ANY ||
  1006                       dev_info->no_160 ==
  1007                       IWL_SUBDEVICE_NO_160(pdev->subsystem_device)) &&

IWL_SUBDEVICE_NO_160() is always zero because 0x100 >> 9 is zero.

  1008                      (dev_info->cores == (u8)IWL_CFG_ANY ||
  1009                       dev_info->cores ==
  1010                       IWL_SUBDEVICE_CORES(pdev->subsystem_device))) {
  1011                          iwl_trans->cfg = dev_info->cfg;
  1012                          iwl_trans->name = dev_info->name;
  1013                  }
  1014          }

regards,
dan carpenter