Re: [Outreachy kernel] [PATCH] staging: greybus: quoted string split across lines

[Stefano Brivio <sbrivio@redhat.com>]

Gökçe,

On Sat, 4 Apr 2020 03:51:22 +0300
Gokce Kuler <gokcekuler@gmail.com> wrote:

> Quoted string merge to upper line.
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/greybus/audio_manager_sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index ab882cc..d7216e9 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -18,8 +18,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj,
>  	struct gb_audio_manager_module_descriptor desc = { {0} };
>  
>  	int num = sscanf(buf,
> -			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s "
> -			"vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> +			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",

Is this reported by...? checkpatch? Because I don't see the problem
with a sscanf().

That is, the rationale for keeping quoted strings unwrapped is that
they end up in kernel logs, and one might want to find the equivalent
point in the sources. But with a sscanf(), I'm not sure we need it.

-- 
Stefano