Re: [PATCH] staging: greybus: quoted string split across lines

[Johan Hovold <johan@kernel.org>]

On Sun, Apr 05, 2020 at 09:15:17AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 04, 2020 at 03:51:22AM +0300, Gokce Kuler wrote:
> > Quoted string merge to upper line.
> > 
> > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > ---
> >  drivers/staging/greybus/audio_manager_sysfs.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> > index ab882cc..d7216e9 100644
> > --- a/drivers/staging/greybus/audio_manager_sysfs.c
> > +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> > @@ -18,8 +18,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj,
> >  	struct gb_audio_manager_module_descriptor desc = { {0} };
> >  
> >  	int num = sscanf(buf,
> > -			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s "
> > -			"vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> > +			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> 
> No, try breaking this line by putting the "s " on the next line, so
> there is only quoted string there.

Not sure that would improve things; I'd say that "s " really does belong on the
same line as the "name=%" and field width define.

As Stefano pointed out, splitting a string like this isn't really an issue with
sscanf either.

I suggest we just leave this one as is.

Johan