All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Tang Bin <tangbin@cmss.chinamobile.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-crypto@vger.kernel.org,
	Colin Ian King <colin.king@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
Date: Sun, 05 Apr 2020 17:56:24 +0000	[thread overview]
Message-ID: <20200405175624.GA24925@Red> (raw)
In-Reply-To: <c7e1193f-7d8b-7da3-a2a8-e92ca0fd83b2@web.de>

On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 6b301afffd11..a1fb2fbdbe7b 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
>  		return err;
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ss->reset = devm_reset_control_get(&pdev->dev, NULL);
>  	if (IS_ERR(ss->reset)) {
> --
> 2.26.0
> 

Hello

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Chen-Yu Tsai <wens@csie.org>,
	Colin Ian King <colin.king@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Maxime Ripard <mripard@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Tang Bin <tangbin@cmss.chinamobile.com>
Subject: Re: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
Date: Sun, 5 Apr 2020 19:56:24 +0200	[thread overview]
Message-ID: <20200405175624.GA24925@Red> (raw)
In-Reply-To: <c7e1193f-7d8b-7da3-a2a8-e92ca0fd83b2@web.de>

On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 6b301afffd11..a1fb2fbdbe7b 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
>  		return err;
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ss->reset = devm_reset_control_get(&pdev->dev, NULL);
>  	if (IS_ERR(ss->reset)) {
> --
> 2.26.0
> 

Hello

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Tang Bin <tangbin@cmss.chinamobile.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-crypto@vger.kernel.org,
	Colin Ian King <colin.king@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
Date: Sun, 5 Apr 2020 19:56:24 +0200	[thread overview]
Message-ID: <20200405175624.GA24925@Red> (raw)
In-Reply-To: <c7e1193f-7d8b-7da3-a2a8-e92ca0fd83b2@web.de>

On Sat, Apr 04, 2020 at 05:45:26PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Apr 2020 17:34:53 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 6b301afffd11..a1fb2fbdbe7b 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
>  		return err;
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(ss->dev, "Cannot get SecuritySystem IRQ\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ss->reset = devm_reset_control_get(&pdev->dev, NULL);
>  	if (IS_ERR(ss->reset)) {
> --
> 2.26.0
> 

Hello

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-05 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04 15:45 [PATCH] crypto: sun8i-ss - Delete an error message in sun8i_ss_probe() Markus Elfring
2020-04-04 15:45 ` Markus Elfring
2020-04-04 15:45 ` Markus Elfring
2020-04-05 17:56 ` Corentin Labbe [this message]
2020-04-05 17:56   ` Corentin Labbe
2020-04-05 17:56   ` Corentin Labbe
2020-04-16  6:51 ` Herbert Xu
2020-04-16  6:51   ` Herbert Xu
2020-04-16  6:51   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405175624.GA24925@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=tangbin@cmss.chinamobile.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.