* [PATCH 1/4] staging: rtl8723bs: include: Correct misspelt symbolic name
2020-04-06 5:24 [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code R Veera Kumar
@ 2020-04-06 5:24 ` R Veera Kumar
2020-04-06 14:23 ` Greg Kroah-Hartman
2020-04-06 5:24 ` [PATCH 2/4] staging: rtl8723bs: hal: " R Veera Kumar
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: R Veera Kumar @ 2020-04-06 5:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel
Correct misspelt symbolic name.
Misspelling found using checkpatch.pl on the dependent file.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/include/hal_data.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index e5e667df6154..fa5d70016f05 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -56,9 +56,9 @@ enum RT_AMPDU_BURST {
/* Tx Power Limit Table Size */
#define MAX_REGULATION_NUM 4
#define MAX_RF_PATH_NUM_IN_POWER_LIMIT_TABLE 4
-#define MAX_2_4G_BANDWITH_NUM 4
+#define MAX_2_4G_BANDWIDTH_NUM 4
#define MAX_RATE_SECTION_NUM 10
-#define MAX_5G_BANDWITH_NUM 4
+#define MAX_5G_BANDWIDTH_NUM 4
#define MAX_BASE_NUM_IN_PHY_REG_PG_2_4G 10 /* CCK:1, OFDM:1, HT:4, VHT:4 */
#define MAX_BASE_NUM_IN_PHY_REG_PG_5G 9 /* OFDM:1, HT:4, VHT:4 */
@@ -280,14 +280,14 @@ struct hal_com_data {
/* Power Limit Table for 2.4G */
s8 TxPwrLimit_2_4G[MAX_REGULATION_NUM]
- [MAX_2_4G_BANDWITH_NUM]
+ [MAX_2_4G_BANDWIDTH_NUM]
[MAX_RATE_SECTION_NUM]
[CHANNEL_MAX_NUMBER_2G]
[MAX_RF_PATH_NUM];
/* Power Limit Table for 5G */
s8 TxPwrLimit_5G[MAX_REGULATION_NUM]
- [MAX_5G_BANDWITH_NUM]
+ [MAX_5G_BANDWIDTH_NUM]
[MAX_RATE_SECTION_NUM]
[CHANNEL_MAX_NUMBER_5G]
[MAX_RF_PATH_NUM];
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/4] staging: rtl8723bs: include: Correct misspelt symbolic name
2020-04-06 5:24 ` [PATCH 1/4] staging: rtl8723bs: include: Correct misspelt symbolic name R Veera Kumar
@ 2020-04-06 14:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-06 14:23 UTC (permalink / raw)
To: R Veera Kumar; +Cc: Hans de Goede, Larry Finger, outreachy-kernel
On Mon, Apr 06, 2020 at 10:54:11AM +0530, R Veera Kumar wrote:
> Correct misspelt symbolic name.
> Misspelling found using checkpatch.pl on the dependent file.
>
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
> drivers/staging/rtl8723bs/include/hal_data.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
> index e5e667df6154..fa5d70016f05 100644
> --- a/drivers/staging/rtl8723bs/include/hal_data.h
> +++ b/drivers/staging/rtl8723bs/include/hal_data.h
> @@ -56,9 +56,9 @@ enum RT_AMPDU_BURST {
> /* Tx Power Limit Table Size */
> #define MAX_REGULATION_NUM 4
> #define MAX_RF_PATH_NUM_IN_POWER_LIMIT_TABLE 4
> -#define MAX_2_4G_BANDWITH_NUM 4
> +#define MAX_2_4G_BANDWIDTH_NUM 4
> #define MAX_RATE_SECTION_NUM 10
> -#define MAX_5G_BANDWITH_NUM 4
> +#define MAX_5G_BANDWIDTH_NUM 4
>
> #define MAX_BASE_NUM_IN_PHY_REG_PG_2_4G 10 /* CCK:1, OFDM:1, HT:4, VHT:4 */
> #define MAX_BASE_NUM_IN_PHY_REG_PG_5G 9 /* OFDM:1, HT:4, VHT:4 */
> @@ -280,14 +280,14 @@ struct hal_com_data {
>
> /* Power Limit Table for 2.4G */
> s8 TxPwrLimit_2_4G[MAX_REGULATION_NUM]
> - [MAX_2_4G_BANDWITH_NUM]
> + [MAX_2_4G_BANDWIDTH_NUM]
> [MAX_RATE_SECTION_NUM]
> [CHANNEL_MAX_NUMBER_2G]
> [MAX_RF_PATH_NUM];
>
> /* Power Limit Table for 5G */
> s8 TxPwrLimit_5G[MAX_REGULATION_NUM]
> - [MAX_5G_BANDWITH_NUM]
> + [MAX_5G_BANDWIDTH_NUM]
> [MAX_RATE_SECTION_NUM]
> [CHANNEL_MAX_NUMBER_5G]
> [MAX_RF_PATH_NUM];
> --
> 2.20.1
>
This patch breaks the build, and as such, I can not apply it :(
Please fix this series up to never break the build, or add any new
warnings, at every step of the way.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4] staging: rtl8723bs: hal: Correct misspelt symbolic name
2020-04-06 5:24 [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code R Veera Kumar
2020-04-06 5:24 ` [PATCH 1/4] staging: rtl8723bs: include: Correct misspelt symbolic name R Veera Kumar
@ 2020-04-06 5:24 ` R Veera Kumar
2020-04-06 5:24 ` [PATCH 3/4] staging: rtl8723bs: hal: Correct misspelt enum name R Veera Kumar
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: R Veera Kumar @ 2020-04-06 5:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel
Correct misspelt symbolic name.
Misspelling found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 767e2a784f78..10250642d30a 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -1816,7 +1816,7 @@ static void phy_CrossReferenceHTAndVHTTxPowerLimit(struct adapter *padapter)
s8 tempPwrLmt = 0;
for (regulation = 0; regulation < MAX_REGULATION_NUM; ++regulation) {
- for (bw = 0; bw < MAX_5G_BANDWITH_NUM; ++bw) {
+ for (bw = 0; bw < MAX_5G_BANDWIDTH_NUM; ++bw) {
for (channel = 0; channel < CHANNEL_MAX_NUMBER_5G; ++channel) {
for (rateSection = 0; rateSection < MAX_RATE_SECTION_NUM; ++rateSection) {
tempPwrLmt = pHalData->TxPwrLimit_5G[regulation][bw][rateSection][channel][ODM_RF_PATH_A];
@@ -1877,7 +1877,7 @@ void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
phy_CrossReferenceHTAndVHTTxPowerLimit(Adapter);
for (regulation = 0; regulation < MAX_REGULATION_NUM; ++regulation) {
- for (bw = 0; bw < MAX_2_4G_BANDWITH_NUM; ++bw) {
+ for (bw = 0; bw < MAX_2_4G_BANDWIDTH_NUM; ++bw) {
for (channel = 0; channel < CHANNEL_MAX_NUMBER_2G; ++channel) {
for (rateSection = 0; rateSection < MAX_RATE_SECTION_NUM; ++rateSection) {
tempPwrLmt = pHalData->TxPwrLimit_2_4G[regulation][bw][rateSection][channel][ODM_RF_PATH_A];
@@ -1920,7 +1920,7 @@ void PHY_InitTxPowerLimit(struct adapter *Adapter)
/* DBG_871X("=====> PHY_InitTxPowerLimit()!\n"); */
for (i = 0; i < MAX_REGULATION_NUM; ++i) {
- for (j = 0; j < MAX_2_4G_BANDWITH_NUM; ++j)
+ for (j = 0; j < MAX_2_4G_BANDWIDTH_NUM; ++j)
for (k = 0; k < MAX_RATE_SECTION_NUM; ++k)
for (m = 0; m < CHANNEL_MAX_NUMBER_2G; ++m)
for (l = 0; l < MAX_RF_PATH_NUM; ++l)
@@ -1928,7 +1928,7 @@ void PHY_InitTxPowerLimit(struct adapter *Adapter)
}
for (i = 0; i < MAX_REGULATION_NUM; ++i) {
- for (j = 0; j < MAX_5G_BANDWITH_NUM; ++j)
+ for (j = 0; j < MAX_5G_BANDWIDTH_NUM; ++j)
for (k = 0; k < MAX_RATE_SECTION_NUM; ++k)
for (m = 0; m < CHANNEL_MAX_NUMBER_5G; ++m)
for (l = 0; l < MAX_RF_PATH_NUM; ++l)
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/4] staging: rtl8723bs: hal: Correct misspelt enum name
2020-04-06 5:24 [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code R Veera Kumar
2020-04-06 5:24 ` [PATCH 1/4] staging: rtl8723bs: include: Correct misspelt symbolic name R Veera Kumar
2020-04-06 5:24 ` [PATCH 2/4] staging: rtl8723bs: hal: " R Veera Kumar
@ 2020-04-06 5:24 ` R Veera Kumar
2020-04-06 5:24 ` [PATCH 4/4] staging: rtl8723bs: hal: Correct misspelled symbolic name R Veera Kumar
2020-04-06 14:22 ` [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code Greg Kroah-Hartman
4 siblings, 0 replies; 7+ messages in thread
From: R Veera Kumar @ 2020-04-06 5:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel
Correct misspelt enum name.
Misspelling found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index b77d1fe33a28..16e8f66a3171 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -541,7 +541,7 @@ typedef enum tag_Operation_Mode_Definition {
/* ODM_CMNINFO_WM_MODE */
typedef enum tag_Wireless_Mode_Definition {
- ODM_WM_UNKNOW = 0x0,
+ ODM_WM_UNKNOWN = 0x0,
ODM_WM_B = BIT0,
ODM_WM_G = BIT1,
ODM_WM_A = BIT2,
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/4] staging: rtl8723bs: hal: Correct misspelled symbolic name
2020-04-06 5:24 [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code R Veera Kumar
` (2 preceding siblings ...)
2020-04-06 5:24 ` [PATCH 3/4] staging: rtl8723bs: hal: Correct misspelt enum name R Veera Kumar
@ 2020-04-06 5:24 ` R Veera Kumar
2020-04-06 14:22 ` [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code Greg Kroah-Hartman
4 siblings, 0 replies; 7+ messages in thread
From: R Veera Kumar @ 2020-04-06 5:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: R Veera Kumar, Hans de Goede, Larry Finger, outreachy-kernel
Correct misspelled symbolic name.
Misspelling found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h b/drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h
index f2c0707aad4c..1c6c08000e27 100644
--- a/drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h
+++ b/drivers/staging/rtl8723bs/hal/odm_RegDefine11N.h
@@ -31,8 +31,8 @@
#define ODM_REG_TX_ANT_CTRL_11N 0x80C
#define ODM_REG_BB_PWR_SAV5_11N 0x818
#define ODM_REG_CCK_RPT_FORMAT_11N 0x824
-#define ODM_REG_RX_DEFUALT_A_11N 0x858
-#define ODM_REG_RX_DEFUALT_B_11N 0x85A
+#define ODM_REG_RX_DEFAULT_A_11N 0x858
+#define ODM_REG_RX_DEFAULT_B_11N 0x85A
#define ODM_REG_BB_PWR_SAV3_11N 0x85C
#define ODM_REG_ANTSEL_CTRL_11N 0x860
#define ODM_REG_RX_ANT_CTRL_11N 0x864
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code
2020-04-06 5:24 [PATCH 0/4] staging: rtl8723bs: Spelling corrections in driver code R Veera Kumar
` (3 preceding siblings ...)
2020-04-06 5:24 ` [PATCH 4/4] staging: rtl8723bs: hal: Correct misspelled symbolic name R Veera Kumar
@ 2020-04-06 14:22 ` Greg Kroah-Hartman
4 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2020-04-06 14:22 UTC (permalink / raw)
To: R Veera Kumar; +Cc: Hans de Goede, Larry Finger, outreachy-kernel
On Mon, Apr 06, 2020 at 10:54:10AM +0530, R Veera Kumar wrote:
> Spelling corrections in driver code.
>
> Patch 1 & 2 are dependent.
Dependent on what?
^ permalink raw reply [flat|nested] 7+ messages in thread