All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit
@ 2020-04-07  9:49 Thomas De Schampheleire
  2020-04-07 10:00 ` Thomas De Schampheleire
  2020-04-08 20:52 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2020-04-07  9:49 UTC (permalink / raw)
  To: buildroot

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Otherwise, the presence of zstd support in libarchive will depend on build
order.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 package/libarchive/libarchive.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 60838eea0a..94f974e7d1 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -112,6 +112,13 @@ else
 LIBARCHIVE_CONF_OPTS += --without-lzma
 endif
 
+ifeq ($(BR2_PACKAGE_ZSTD),y)
+LIBARCHIVE_DEPENDENCIES += zstd
+LIBARCHIVE_CONF_OPTS += --with-zstd
+else
+LIBARCHIVE_CONF_OPTS += --without-zstd
+endif
+
 # The only user of host-libarchive needs zlib support
 HOST_LIBARCHIVE_DEPENDENCIES = host-zlib
 HOST_LIBARCHIVE_CONF_OPTS = \
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit
  2020-04-07  9:49 [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit Thomas De Schampheleire
@ 2020-04-07 10:00 ` Thomas De Schampheleire
  2020-04-08 20:52 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2020-04-07 10:00 UTC (permalink / raw)
  To: buildroot

El mar., 7 abr. 2020 a las 11:49, Thomas De Schampheleire
(<patrickdepinguin@gmail.com>) escribi?:
>
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> Otherwise, the presence of zstd support in libarchive will depend on build
> order.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
>  package/libarchive/libarchive.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> index 60838eea0a..94f974e7d1 100644
> --- a/package/libarchive/libarchive.mk
> +++ b/package/libarchive/libarchive.mk
> @@ -112,6 +112,13 @@ else
>  LIBARCHIVE_CONF_OPTS += --without-lzma
>  endif
>
> +ifeq ($(BR2_PACKAGE_ZSTD),y)
> +LIBARCHIVE_DEPENDENCIES += zstd
> +LIBARCHIVE_CONF_OPTS += --with-zstd
> +else
> +LIBARCHIVE_CONF_OPTS += --without-zstd
> +endif
> +
>  # The only user of host-libarchive needs zlib support
>  HOST_LIBARCHIVE_DEPENDENCIES = host-zlib
>  HOST_LIBARCHIVE_CONF_OPTS = \
> --
> 2.24.1

In my view this should be applied on both master and 2020.02.y.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit
  2020-04-07  9:49 [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit Thomas De Schampheleire
  2020-04-07 10:00 ` Thomas De Schampheleire
@ 2020-04-08 20:52 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-04-08 20:52 UTC (permalink / raw)
  To: buildroot

On Tue,  7 Apr 2020 11:49:49 +0200
Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> 
> Otherwise, the presence of zstd support in libarchive will depend on build
> order.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
>  package/libarchive/libarchive.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-08 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-07  9:49 [Buildroot] [PATCH] package/libarchive: make optional zstd dependency explicit Thomas De Schampheleire
2020-04-07 10:00 ` Thomas De Schampheleire
2020-04-08 20:52 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.