From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Chris Park" <Chris.Park@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Zhan Liu" <Zhan.Liu@amd.com>,
kernel-janitors@vger.kernel.org, "Roman Li" <Roman.Li@amd.com>,
amd-gfx@lists.freedesktop.org,
"Wenjing Liu" <Wenjing.Liu@amd.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Nikola Cornij" <nikola.cornij@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Lucy Li" <lucy.li@amd.com>, "Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Galiffi" <David.Galiffi@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>
Subject: Re: [PATCH net-next] drm/amd/display: Fix link_detect_sink()
Date: Tue, 7 Apr 2020 15:58:02 +0300 [thread overview]
Message-ID: <20200407125802.GK2001@kadam> (raw)
In-Reply-To: <7ab9e9de-8d78-7f63-f2b3-c1e9669faa6d@amd.com>
On Mon, Apr 06, 2020 at 12:22:51PM -0400, Kazlauskas, Nicholas wrote:
> On 2020-04-06 5:19 a.m., Dan Carpenter wrote:
> > This TODO stub originally had curly braces but we deleted them as part
> > of a clean up. Unfortunately that changes the behavior of the code
> > because now the switch statement is part of the if statement. Smatch
> > complains that the indenting doesn't make sense.
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:425
> > link_detect_sink() warn: if statement not indented
> >
> > Also I changed "ZAZTODO" to just "TODO". The ZAZ isn't used anywhere
> > else.
> >
> > Fixes: 621514aa4140 ("drm/amd/display: codestyle cleanup on dc_link file until detect_dp func")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I'd prefer just dropping the block, but either method is:
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Since that previous patch broke most sink detection...
>
Sorry for the net-next in the subject. Anyway, this was fixed in
commit 50dc581a8f43 ("drm/amd/display: fix the broken logic in dc_link.c")
so no need for me to resend.
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Chris Park" <Chris.Park@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Zhan Liu" <Zhan.Liu@amd.com>,
kernel-janitors@vger.kernel.org, "Roman Li" <Roman.Li@amd.com>,
amd-gfx@lists.freedesktop.org,
"Wenjing Liu" <Wenjing.Liu@amd.com>,
"Melissa Wen" <melissa.srw@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Nikola Cornij" <nikola.cornij@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Lucy Li" <lucy.li@amd.com>, "Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Galiffi" <David.Galiffi@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>
Subject: Re: [PATCH net-next] drm/amd/display: Fix link_detect_sink()
Date: Tue, 07 Apr 2020 12:58:02 +0000 [thread overview]
Message-ID: <20200407125802.GK2001@kadam> (raw)
In-Reply-To: <7ab9e9de-8d78-7f63-f2b3-c1e9669faa6d@amd.com>
On Mon, Apr 06, 2020 at 12:22:51PM -0400, Kazlauskas, Nicholas wrote:
> On 2020-04-06 5:19 a.m., Dan Carpenter wrote:
> > This TODO stub originally had curly braces but we deleted them as part
> > of a clean up. Unfortunately that changes the behavior of the code
> > because now the switch statement is part of the if statement. Smatch
> > complains that the indenting doesn't make sense.
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:425
> > link_detect_sink() warn: if statement not indented
> >
> > Also I changed "ZAZTODO" to just "TODO". The ZAZ isn't used anywhere
> > else.
> >
> > Fixes: 621514aa4140 ("drm/amd/display: codestyle cleanup on dc_link file until detect_dp func")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I'd prefer just dropping the block, but either method is:
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Since that previous patch broke most sink detection...
>
Sorry for the net-next in the subject. Anyway, this was fixed in
commit 50dc581a8f43 ("drm/amd/display: fix the broken logic in dc_link.c")
so no need for me to resend.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-07 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 9:19 [PATCH net-next] drm/amd/display: Fix link_detect_sink() Dan Carpenter
2020-04-06 9:19 ` Dan Carpenter
2020-04-06 16:22 ` Kazlauskas, Nicholas
2020-04-06 16:22 ` Kazlauskas, Nicholas
2020-04-07 12:58 ` Dan Carpenter [this message]
2020-04-07 12:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407125802.GK2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Chris.Park@amd.com \
--cc=David.Galiffi@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Roman.Li@amd.com \
--cc=Wenjing.Liu@amd.com \
--cc=Zhan.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=harry.wentland@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lucy.li@amd.com \
--cc=melissa.srw@gmail.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=nikola.cornij@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.