From: Andrew Lunn <andrew@lunn.ch>
To: Paul Spooren <mail@aparcar.org>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
daniel@makrotopia.org, freifunk@adrianschmutzler.de,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 0/5] arm: dts: linksys: rename codename to model
Date: Wed, 8 Apr 2020 00:46:15 +0200 [thread overview]
Message-ID: <20200407224615.GA359603@lunn.ch> (raw)
In-Reply-To: <20200407210816.866084-1-mail@aparcar.org>
On Tue, Apr 07, 2020 at 11:08:10AM -1000, Paul Spooren wrote:
> Linksys chose to use codenames for a few of their devices and sell their
> them under an entirely different name.
>
> codename model name
> rango -> wrt3200acm
> mamba -> wrt1900ac
> cobra -> wrt1900ac-v2
> caiman -> wrt1200ac
> shelby -> wrt1900acs
Hi Paul
There was quite a bit of discussion about this when the first board
was added. If i remember correctly, it was Mamba.
Imre Kaloz, <kaloz@openwrt.org> was the one arguing for
the name armada-xp-linksys-mamba.dts.
So it seems that openwrt.org has now come full circle?
> This introduces some extra loops in OpenWrt, a distribution specialized
> on embedded Internet facing devices, as both codename and model name are
> used within the build system. The double naming requires developers to
> keep track of that mapping and introduces inconsistencies:
>
> To build a specific device in OpenWrt profiles are used, named after the
> the compatible string for targets using device tree (similar to how .dts
> files are named in the linux source tree). However, the first item of
> the DT `compatible` list in this case is `linksys,rango`, which is
> inconsistent with the model name and not what common users would expect.
>
> Such double naming complicates currently the automatic search for
> firmware upgrade as the build system does not support such mapping.
> Ideally the first item of the DT `compatible` list would contain a
> string suitable to be used as a filename recognizable by normal users to
> belong to that device.
> With this patch set the Linksys device tree files are moved from
> containing the codename to contain a sanitized model name and also use
> it as first entry of the DT `compatible` list.
I've no problems adding another compatible to the list. But i don't
like the idea of renaming the files. The file names could be
considered ABI! What installers/bootloaders are you going to break by
renaming them?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Paul Spooren <mail@aparcar.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
jason@lakedaemon.net, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, daniel@makrotopia.org,
freifunk@adrianschmutzler.de
Subject: Re: [PATCH 0/5] arm: dts: linksys: rename codename to model
Date: Wed, 8 Apr 2020 00:46:15 +0200 [thread overview]
Message-ID: <20200407224615.GA359603@lunn.ch> (raw)
In-Reply-To: <20200407210816.866084-1-mail@aparcar.org>
On Tue, Apr 07, 2020 at 11:08:10AM -1000, Paul Spooren wrote:
> Linksys chose to use codenames for a few of their devices and sell their
> them under an entirely different name.
>
> codename model name
> rango -> wrt3200acm
> mamba -> wrt1900ac
> cobra -> wrt1900ac-v2
> caiman -> wrt1200ac
> shelby -> wrt1900acs
Hi Paul
There was quite a bit of discussion about this when the first board
was added. If i remember correctly, it was Mamba.
Imre Kaloz, <kaloz@openwrt.org> was the one arguing for
the name armada-xp-linksys-mamba.dts.
So it seems that openwrt.org has now come full circle?
> This introduces some extra loops in OpenWrt, a distribution specialized
> on embedded Internet facing devices, as both codename and model name are
> used within the build system. The double naming requires developers to
> keep track of that mapping and introduces inconsistencies:
>
> To build a specific device in OpenWrt profiles are used, named after the
> the compatible string for targets using device tree (similar to how .dts
> files are named in the linux source tree). However, the first item of
> the DT `compatible` list in this case is `linksys,rango`, which is
> inconsistent with the model name and not what common users would expect.
>
> Such double naming complicates currently the automatic search for
> firmware upgrade as the build system does not support such mapping.
> Ideally the first item of the DT `compatible` list would contain a
> string suitable to be used as a filename recognizable by normal users to
> belong to that device.
> With this patch set the Linksys device tree files are moved from
> containing the codename to contain a sanitized model name and also use
> it as first entry of the DT `compatible` list.
I've no problems adding another compatible to the list. But i don't
like the idea of renaming the files. The file names could be
considered ABI! What installers/bootloaders are you going to break by
renaming them?
Andrew
next prev parent reply other threads:[~2020-04-07 22:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 21:08 [PATCH 0/5] arm: dts: linksys: rename codename to model Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 1/5] arm: dts: linksys: rename rango to wrt3200acm Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 2/5] arm: dts: linksys: rename mamba to wrt1900ac Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 3/5] arm: dts: linksys: rename cobra to wrt1900ac-v2 Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 4/5] arm: dts: linksys: rename caiman to wrt1200ac Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 5/5] arm: dts: linksys: rename shelby to wrt1900acs Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 21:08 ` [PATCH 0/5] arm: dts: linksys: rename codename to model Paul Spooren
2020-04-07 21:08 ` Paul Spooren
2020-04-07 22:46 ` Andrew Lunn [this message]
2020-04-07 22:46 ` Andrew Lunn
2020-04-07 23:38 ` Paul Spooren
2020-04-07 23:38 ` Paul Spooren
2020-04-08 0:07 ` Florian Fainelli
2020-04-08 0:07 ` Florian Fainelli
[not found] ` <VI1PR02MB5325621D39BF0FFAFE3993C4A0C00@VI1PR02MB5325.eurprd02.prod.outlook.com>
2020-04-08 16:23 ` Daniel Golle
2020-04-08 16:23 ` Daniel Golle
2020-04-10 9:49 ` Paul Spooren
2020-04-10 9:49 ` Paul Spooren
2020-04-08 0:09 ` Andrew Lunn
2020-04-08 0:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407224615.GA359603@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=freifunk@adrianschmutzler.de \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aparcar.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.