Re: [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Apr 08, 2020 at 01:05:46AM +0000, Ankur Tyagi wrote:
> Hi Denys
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org <meta-arago-bounces@arago-
> > project.org> On Behalf Of Denys Dmytriyenko
> > Sent: Wednesday, 8 April 2020 12:51 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [master][PATCH] arago.conf, packagegroup-arago-tisdk-
> > qte: enable examples PACKAGECONFIG for qt5 modules
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > qtdeclarative-examples is broken for now.
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  meta-arago-distro/conf/distro/arago.conf                     | 12 +++++++++++-
> >  .../packagegroups/packagegroup-arago-tisdk-qte.bb            |  2 +-
> >  2 files changed, 12 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-
> > distro/conf/distro/arago.conf
> > index 3215fe7..05201f3 100644
> > --- a/meta-arago-distro/conf/distro/arago.conf
> > +++ b/meta-arago-distro/conf/distro/arago.conf
> > @@ -103,7 +103,17 @@ PACKAGECONFIG_DISTRO_pn-qtbase = "icu examples
> > accessibility gif gbm kms libinpu  PACKAGECONFIG_FONTS_pn-qtbase =
> > "fontconfig"
> > 
> >  # Add gstreamer in package configuration to enable video -
> > PACKAGECONFIG_append_pn-qtmultimedia  = " gstreamer"
> > +PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> > +
> > +# Add examples in Qt5 package configurations
> > +PACKAGECONFIG_append_pn-qtcharts = " examples"
> > +#PACKAGECONFIG_append_pn-qtdeclarative = " examples"
> > +PACKAGECONFIG_append_pn-qtlocation = " examples"
> > +PACKAGECONFIG_append_pn-qtmultimedia = " examples"
> > +PACKAGECONFIG_append_pn-qtscript = " examples"
> > +PACKAGECONFIG_append_pn-qtserialport = " examples"
> > +PACKAGECONFIG_append_pn-qtsvg = " examples"
> > +PACKAGECONFIG_append_pn-qtwayland = " examples"
> 
> That means every image including Qt5 based on arago now have to override these
> PACKAGECONFIG in bbappends as I don't expect anyone to include examples in their
> production image.
> Could this inclusion of examples in PACKAGECONFIG be handled in a better way that doesn't
> impact other arago users? Somewhere inside packagegroup-arago-tisdk-qte?

That's not how it works. PACKAGECONFIG controls what gets built, and not what 
gets included into the images.

This patch actually restores existing behavior - meta-qt5 used to enable 
examples for all qt5 modules, based on qtbase PACKAGECONFIG, which is already 
set above. Now meta-qt5 requires "examples" PACKAGECONFIG for each individual 
qt5 module.

And packagegroup-arago-tisdk-qte below already had all corresponding examples 
packages listed to be added into our default image. But you are free not to 
include such packages into your production image - it's as simple as not 
listing them in corresponding RDEPENDS on IMAGE_INSTALL...

-- 
Denys


> >  # Prefer OpenSSL over GnuTLS for curl due to TSU exemptions
> > PACKAGECONFIG_pn-curl = "${@bb.utils.contains("DISTRO_FEATURES", "ipv6",
> > "ipv6", "", d)} ssl zlib"
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-tisdk-qte.bb b/meta-arago-distro/recipes-
> > core/packagegroups/packagegroup-arago-tisdk-qte.bb
> > index f83ac52..a2e3794 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > tisdk-qte.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-ti
> > +++ sdk-qte.bb
> > @@ -12,9 +12,9 @@ QT4_DEMOS = "\
> >      ${@oe.utils.conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles',
> > 'quick-playground', '', d)} \  "
> > 
> > +#    qtdeclarative-examples
> >  QT5_DEMOS = "\
> >      qtbase-examples \
> > -    qtdeclarative-examples \
> >      qtdeclarative-tools \
> >      qtlocation-examples \
> >      qtmultimedia-examples \
> > --
> > 2.7.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago