* [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules
@ 2020-04-08 0:51 Denys Dmytriyenko
2020-04-08 1:05 ` Ankur Tyagi
0 siblings, 1 reply; 4+ messages in thread
From: Denys Dmytriyenko @ 2020-04-08 0:51 UTC (permalink / raw)
To: meta-arago
From: Denys Dmytriyenko <denys@ti.com>
qtdeclarative-examples is broken for now.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
meta-arago-distro/conf/distro/arago.conf | 12 +++++++++++-
.../packagegroups/packagegroup-arago-tisdk-qte.bb | 2 +-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index 3215fe7..05201f3 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -103,7 +103,17 @@ PACKAGECONFIG_DISTRO_pn-qtbase = "icu examples accessibility gif gbm kms libinpu
PACKAGECONFIG_FONTS_pn-qtbase = "fontconfig"
# Add gstreamer in package configuration to enable video
-PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
+PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
+
+# Add examples in Qt5 package configurations
+PACKAGECONFIG_append_pn-qtcharts = " examples"
+#PACKAGECONFIG_append_pn-qtdeclarative = " examples"
+PACKAGECONFIG_append_pn-qtlocation = " examples"
+PACKAGECONFIG_append_pn-qtmultimedia = " examples"
+PACKAGECONFIG_append_pn-qtscript = " examples"
+PACKAGECONFIG_append_pn-qtserialport = " examples"
+PACKAGECONFIG_append_pn-qtsvg = " examples"
+PACKAGECONFIG_append_pn-qtwayland = " examples"
# Prefer OpenSSL over GnuTLS for curl due to TSU exemptions
PACKAGECONFIG_pn-curl = "${@bb.utils.contains("DISTRO_FEATURES", "ipv6", "ipv6", "", d)} ssl zlib"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
index f83ac52..a2e3794 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
@@ -12,9 +12,9 @@ QT4_DEMOS = "\
${@oe.utils.conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles', 'quick-playground', '', d)} \
"
+# qtdeclarative-examples
QT5_DEMOS = "\
qtbase-examples \
- qtdeclarative-examples \
qtdeclarative-tools \
qtlocation-examples \
qtmultimedia-examples \
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules
2020-04-08 0:51 [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules Denys Dmytriyenko
@ 2020-04-08 1:05 ` Ankur Tyagi
2020-04-08 7:29 ` Denys Dmytriyenko
0 siblings, 1 reply; 4+ messages in thread
From: Ankur Tyagi @ 2020-04-08 1:05 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-arago@arago-project.org
Hi Denys
> -----Original Message-----
> From: meta-arago-bounces@arago-project.org <meta-arago-bounces@arago-
> project.org> On Behalf Of Denys Dmytriyenko
> Sent: Wednesday, 8 April 2020 12:51 PM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [master][PATCH] arago.conf, packagegroup-arago-tisdk-
> qte: enable examples PACKAGECONFIG for qt5 modules
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> qtdeclarative-examples is broken for now.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> meta-arago-distro/conf/distro/arago.conf | 12 +++++++++++-
> .../packagegroups/packagegroup-arago-tisdk-qte.bb | 2 +-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-
> distro/conf/distro/arago.conf
> index 3215fe7..05201f3 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -103,7 +103,17 @@ PACKAGECONFIG_DISTRO_pn-qtbase = "icu examples
> accessibility gif gbm kms libinpu PACKAGECONFIG_FONTS_pn-qtbase =
> "fontconfig"
>
> # Add gstreamer in package configuration to enable video -
> PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> +PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> +
> +# Add examples in Qt5 package configurations
> +PACKAGECONFIG_append_pn-qtcharts = " examples"
> +#PACKAGECONFIG_append_pn-qtdeclarative = " examples"
> +PACKAGECONFIG_append_pn-qtlocation = " examples"
> +PACKAGECONFIG_append_pn-qtmultimedia = " examples"
> +PACKAGECONFIG_append_pn-qtscript = " examples"
> +PACKAGECONFIG_append_pn-qtserialport = " examples"
> +PACKAGECONFIG_append_pn-qtsvg = " examples"
> +PACKAGECONFIG_append_pn-qtwayland = " examples"
That means every image including Qt5 based on arago now have to override these
PACKAGECONFIG in bbappends as I don't expect anyone to include examples in their
production image.
Could this inclusion of examples in PACKAGECONFIG be handled in a better way that doesn't
impact other arago users? Somewhere inside packagegroup-arago-tisdk-qte?
Regards
Ankur
> # Prefer OpenSSL over GnuTLS for curl due to TSU exemptions
> PACKAGECONFIG_pn-curl = "${@bb.utils.contains("DISTRO_FEATURES", "ipv6",
> "ipv6", "", d)} ssl zlib"
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-tisdk-qte.bb b/meta-arago-distro/recipes-
> core/packagegroups/packagegroup-arago-tisdk-qte.bb
> index f83ac52..a2e3794 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> tisdk-qte.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-ti
> +++ sdk-qte.bb
> @@ -12,9 +12,9 @@ QT4_DEMOS = "\
> ${@oe.utils.conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles',
> 'quick-playground', '', d)} \ "
>
> +# qtdeclarative-examples
> QT5_DEMOS = "\
> qtbase-examples \
> - qtdeclarative-examples \
> qtdeclarative-tools \
> qtlocation-examples \
> qtmultimedia-examples \
> --
> 2.7.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules
2020-04-08 1:05 ` Ankur Tyagi
@ 2020-04-08 7:29 ` Denys Dmytriyenko
2020-04-08 10:32 ` Ankur Tyagi
0 siblings, 1 reply; 4+ messages in thread
From: Denys Dmytriyenko @ 2020-04-08 7:29 UTC (permalink / raw)
To: Ankur Tyagi; +Cc: meta-arago@arago-project.org
On Wed, Apr 08, 2020 at 01:05:46AM +0000, Ankur Tyagi wrote:
> Hi Denys
>
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org <meta-arago-bounces@arago-
> > project.org> On Behalf Of Denys Dmytriyenko
> > Sent: Wednesday, 8 April 2020 12:51 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [master][PATCH] arago.conf, packagegroup-arago-tisdk-
> > qte: enable examples PACKAGECONFIG for qt5 modules
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > qtdeclarative-examples is broken for now.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > meta-arago-distro/conf/distro/arago.conf | 12 +++++++++++-
> > .../packagegroups/packagegroup-arago-tisdk-qte.bb | 2 +-
> > 2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-
> > distro/conf/distro/arago.conf
> > index 3215fe7..05201f3 100644
> > --- a/meta-arago-distro/conf/distro/arago.conf
> > +++ b/meta-arago-distro/conf/distro/arago.conf
> > @@ -103,7 +103,17 @@ PACKAGECONFIG_DISTRO_pn-qtbase = "icu examples
> > accessibility gif gbm kms libinpu PACKAGECONFIG_FONTS_pn-qtbase =
> > "fontconfig"
> >
> > # Add gstreamer in package configuration to enable video -
> > PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> > +PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> > +
> > +# Add examples in Qt5 package configurations
> > +PACKAGECONFIG_append_pn-qtcharts = " examples"
> > +#PACKAGECONFIG_append_pn-qtdeclarative = " examples"
> > +PACKAGECONFIG_append_pn-qtlocation = " examples"
> > +PACKAGECONFIG_append_pn-qtmultimedia = " examples"
> > +PACKAGECONFIG_append_pn-qtscript = " examples"
> > +PACKAGECONFIG_append_pn-qtserialport = " examples"
> > +PACKAGECONFIG_append_pn-qtsvg = " examples"
> > +PACKAGECONFIG_append_pn-qtwayland = " examples"
>
> That means every image including Qt5 based on arago now have to override these
> PACKAGECONFIG in bbappends as I don't expect anyone to include examples in their
> production image.
> Could this inclusion of examples in PACKAGECONFIG be handled in a better way that doesn't
> impact other arago users? Somewhere inside packagegroup-arago-tisdk-qte?
That's not how it works. PACKAGECONFIG controls what gets built, and not what
gets included into the images.
This patch actually restores existing behavior - meta-qt5 used to enable
examples for all qt5 modules, based on qtbase PACKAGECONFIG, which is already
set above. Now meta-qt5 requires "examples" PACKAGECONFIG for each individual
qt5 module.
And packagegroup-arago-tisdk-qte below already had all corresponding examples
packages listed to be added into our default image. But you are free not to
include such packages into your production image - it's as simple as not
listing them in corresponding RDEPENDS on IMAGE_INSTALL...
--
Denys
> > # Prefer OpenSSL over GnuTLS for curl due to TSU exemptions
> > PACKAGECONFIG_pn-curl = "${@bb.utils.contains("DISTRO_FEATURES", "ipv6",
> > "ipv6", "", d)} ssl zlib"
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-tisdk-qte.bb b/meta-arago-distro/recipes-
> > core/packagegroups/packagegroup-arago-tisdk-qte.bb
> > index f83ac52..a2e3794 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > tisdk-qte.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-ti
> > +++ sdk-qte.bb
> > @@ -12,9 +12,9 @@ QT4_DEMOS = "\
> > ${@oe.utils.conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles',
> > 'quick-playground', '', d)} \ "
> >
> > +# qtdeclarative-examples
> > QT5_DEMOS = "\
> > qtbase-examples \
> > - qtdeclarative-examples \
> > qtdeclarative-tools \
> > qtlocation-examples \
> > qtmultimedia-examples \
> > --
> > 2.7.4
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules
2020-04-08 7:29 ` Denys Dmytriyenko
@ 2020-04-08 10:32 ` Ankur Tyagi
0 siblings, 0 replies; 4+ messages in thread
From: Ankur Tyagi @ 2020-04-08 10:32 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-arago@arago-project.org
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Wednesday, 8 April 2020 7:29 PM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: Denys Dmytriyenko <denis@denix.org>; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [master][PATCH] arago.conf, packagegroup-arago-
> tisdk-qte: enable examples PACKAGECONFIG for qt5 modules
>
> On Wed, Apr 08, 2020 at 01:05:46AM +0000, Ankur Tyagi wrote:
> > Hi Denys
> >
> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org <meta-arago-
> bounces@arago-
> > > project.org> On Behalf Of Denys Dmytriyenko
> > > Sent: Wednesday, 8 April 2020 12:51 PM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [master][PATCH] arago.conf, packagegroup-arago-
> tisdk-
> > > qte: enable examples PACKAGECONFIG for qt5 modules
> > >
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > qtdeclarative-examples is broken for now.
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > > meta-arago-distro/conf/distro/arago.conf | 12 +++++++++++-
> > > .../packagegroups/packagegroup-arago-tisdk-qte.bb | 2 +-
> > > 2 files changed, 12 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-
> > > distro/conf/distro/arago.conf
> > > index 3215fe7..05201f3 100644
> > > --- a/meta-arago-distro/conf/distro/arago.conf
> > > +++ b/meta-arago-distro/conf/distro/arago.conf
> > > @@ -103,7 +103,17 @@ PACKAGECONFIG_DISTRO_pn-qtbase = "icu
> examples
> > > accessibility gif gbm kms libinpu PACKAGECONFIG_FONTS_pn-qtbase =
> > > "fontconfig"
> > >
> > > # Add gstreamer in package configuration to enable video -
> > > PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> > > +PACKAGECONFIG_append_pn-qtmultimedia = " gstreamer"
> > > +
> > > +# Add examples in Qt5 package configurations
> > > +PACKAGECONFIG_append_pn-qtcharts = " examples"
> > > +#PACKAGECONFIG_append_pn-qtdeclarative = " examples"
> > > +PACKAGECONFIG_append_pn-qtlocation = " examples"
> > > +PACKAGECONFIG_append_pn-qtmultimedia = " examples"
> > > +PACKAGECONFIG_append_pn-qtscript = " examples"
> > > +PACKAGECONFIG_append_pn-qtserialport = " examples"
> > > +PACKAGECONFIG_append_pn-qtsvg = " examples"
> > > +PACKAGECONFIG_append_pn-qtwayland = " examples"
> >
> > That means every image including Qt5 based on arago now have to override
> these
> > PACKAGECONFIG in bbappends as I don't expect anyone to include examples in
> their
> > production image.
> > Could this inclusion of examples in PACKAGECONFIG be handled in a better
> way that doesn't
> > impact other arago users? Somewhere inside packagegroup-arago-tisdk-qte?
>
> That's not how it works. PACKAGECONFIG controls what gets built, and not what
> gets included into the images.
>
> This patch actually restores existing behavior - meta-qt5 used to enable
> examples for all qt5 modules, based on qtbase PACKAGECONFIG, which is
> already
> set above. Now meta-qt5 requires "examples" PACKAGECONFIG for each
> individual
> qt5 module.
>
> And packagegroup-arago-tisdk-qte below already had all corresponding
> examples
> packages listed to be added into our default image. But you are free not to
> include such packages into your production image - it's as simple as not
> listing them in corresponding RDEPENDS on IMAGE_INSTALL...
>
Ahh, thanks for explanation. So it will only add to build time which isn't of much
concern.
> --
> Denys
>
>
> > > # Prefer OpenSSL over GnuTLS for curl due to TSU exemptions
> > > PACKAGECONFIG_pn-curl = "${@bb.utils.contains("DISTRO_FEATURES",
> "ipv6",
> > > "ipv6", "", d)} ssl zlib"
> > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > > arago-tisdk-qte.bb b/meta-arago-distro/recipes-
> > > core/packagegroups/packagegroup-arago-tisdk-qte.bb
> > > index f83ac52..a2e3794 100644
> > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > tisdk-qte.bb
> > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-ti
> > > +++ sdk-qte.bb
> > > @@ -12,9 +12,9 @@ QT4_DEMOS = "\
> > > ${@oe.utils.conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles',
> > > 'quick-playground', '', d)} \ "
> > >
> > > +# qtdeclarative-examples
> > > QT5_DEMOS = "\
> > > qtbase-examples \
> > > - qtdeclarative-examples \
> > > qtdeclarative-tools \
> > > qtlocation-examples \
> > > qtmultimedia-examples \
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-08 0:51 [master][PATCH] arago.conf, packagegroup-arago-tisdk-qte: enable examples PACKAGECONFIG for qt5 modules Denys Dmytriyenko
2020-04-08 1:05 ` Ankur Tyagi
2020-04-08 7:29 ` Denys Dmytriyenko
2020-04-08 10:32 ` Ankur Tyagi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.