All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Lokesh Vutla <lokeshvutla@ti.com>, Sekhar Nori <nsekhar@ti.com>,
	linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] irqchip/ti-sci-inta: fix processing of masked irqs
Date: Thu, 9 Apr 2020 10:31:44 +0100	[thread overview]
Message-ID: <20200409103144.3b2169bf@why> (raw)
In-Reply-To: <20200408191532.31252-1-grygorii.strashko@ti.com>

On Wed, 8 Apr 2020 22:15:32 +0300
Grygorii Strashko <grygorii.strashko@ti.com> wrote:

> The ti_sci_inta_irq_handler() does not take into account INTA IRQs state
> (masked/unmasked) as it uses INTA_STATUS_CLEAR_j register to get INTA IRQs
> status, which provides raw status value.
> This causes hard IRQ handlers to be called or threaded handlers to be
> scheduled many times even if corresponding INTA IRQ is masked.
> Above, first of all, affects the LEVEL interrupts processing and causes
> unexpected behavior up the system stack or crash.
> 
> Fix it by using the Interrupt Masked Status INTA_STATUSM_j register which
> provides masked INTA IRQs status.
> 
> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Given the failure mode, doesn't this deserve a Cc stable?

> ---
>  drivers/irqchip/irq-ti-sci-inta.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 8f6e6b08eadf..7e3ebf6ed2cd 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -37,6 +37,7 @@
>  #define VINT_ENABLE_SET_OFFSET	0x0
>  #define VINT_ENABLE_CLR_OFFSET	0x8
>  #define VINT_STATUS_OFFSET	0x18
> +#define VINT_STATUS_MASKED_OFFSET	0x20
>  
>  /**
>   * struct ti_sci_inta_event_desc - Description of an event coming to
> @@ -116,7 +117,7 @@ static void ti_sci_inta_irq_handler(struct irq_desc *desc)
>  	chained_irq_enter(irq_desc_get_chip(desc), desc);
>  
>  	val = readq_relaxed(inta->base + vint_desc->vint_id * 0x1000 +
> -			    VINT_STATUS_OFFSET);
> +			    VINT_STATUS_MASKED_OFFSET);
>  
>  	for_each_set_bit(bit, &val, MAX_EVENTS_PER_VINT) {
>  		virq = irq_find_mapping(domain, vint_desc->events[bit].hwirq);


Otherwise queued for post -rc1.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/ti-sci-inta: fix processing of masked irqs
Date: Thu, 9 Apr 2020 10:31:44 +0100	[thread overview]
Message-ID: <20200409103144.3b2169bf@why> (raw)
In-Reply-To: <20200408191532.31252-1-grygorii.strashko@ti.com>

On Wed, 8 Apr 2020 22:15:32 +0300
Grygorii Strashko <grygorii.strashko@ti.com> wrote:

> The ti_sci_inta_irq_handler() does not take into account INTA IRQs state
> (masked/unmasked) as it uses INTA_STATUS_CLEAR_j register to get INTA IRQs
> status, which provides raw status value.
> This causes hard IRQ handlers to be called or threaded handlers to be
> scheduled many times even if corresponding INTA IRQ is masked.
> Above, first of all, affects the LEVEL interrupts processing and causes
> unexpected behavior up the system stack or crash.
> 
> Fix it by using the Interrupt Masked Status INTA_STATUSM_j register which
> provides masked INTA IRQs status.
> 
> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Given the failure mode, doesn't this deserve a Cc stable?

> ---
>  drivers/irqchip/irq-ti-sci-inta.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 8f6e6b08eadf..7e3ebf6ed2cd 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -37,6 +37,7 @@
>  #define VINT_ENABLE_SET_OFFSET	0x0
>  #define VINT_ENABLE_CLR_OFFSET	0x8
>  #define VINT_STATUS_OFFSET	0x18
> +#define VINT_STATUS_MASKED_OFFSET	0x20
>  
>  /**
>   * struct ti_sci_inta_event_desc - Description of an event coming to
> @@ -116,7 +117,7 @@ static void ti_sci_inta_irq_handler(struct irq_desc *desc)
>  	chained_irq_enter(irq_desc_get_chip(desc), desc);
>  
>  	val = readq_relaxed(inta->base + vint_desc->vint_id * 0x1000 +
> -			    VINT_STATUS_OFFSET);
> +			    VINT_STATUS_MASKED_OFFSET);
>  
>  	for_each_set_bit(bit, &val, MAX_EVENTS_PER_VINT) {
>  		virq = irq_find_mapping(domain, vint_desc->events[bit].hwirq);


Otherwise queued for post -rc1.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2020-04-09  9:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 19:15 [PATCH] irqchip/ti-sci-inta: fix processing of masked irqs Grygorii Strashko
2020-04-08 19:15 ` Grygorii Strashko
2020-04-09  5:59 ` Lokesh Vutla
2020-04-09  5:59   ` Lokesh Vutla
2020-04-09  9:31 ` Marc Zyngier [this message]
2020-04-09  9:31   ` Marc Zyngier
2020-04-09 11:11   ` Grygorii Strashko
2020-04-09 11:11     ` Grygorii Strashko
2020-04-09 11:17     ` Marc Zyngier
2020-04-09 11:17       ` Marc Zyngier
2020-04-17  9:56 ` [tip: irq/urgent] irqchip/ti-sci-inta: Fix " tip-bot2 for Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409103144.3b2169bf@why \
    --to=maz@kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.