All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: Eric Anholt <eric@anholt.net>,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: pl111: Fix module autoloading
Date: Thu, 9 Apr 2020 16:12:10 +0200	[thread overview]
Message-ID: <20200409141210.GA4673@ravnborg.org> (raw)
In-Reply-To: <20200409013947.12667-2-robh@kernel.org>

Hi Rob.

On Wed, Apr 08, 2020 at 07:39:45PM -0600, Rob Herring wrote:
> Add a missing MODULE_DEVICE_TABLE entry to fix module autoloading.
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Change looks straightforward.
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/drm/pl111/pl111_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index aa8aa8d9e405..7f405b1374c2 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -444,6 +444,7 @@ static const struct amba_id pl111_id_table[] = {
>  	},
>  	{0, 0},
>  };
> +MODULE_DEVICE_TABLE(amba, pl111_id_table);
>  
>  static struct amba_driver pl111_amba_driver __maybe_unused = {
>  	.drv = {
> -- 
> 2.20.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: pl111: Fix module autoloading
Date: Thu, 9 Apr 2020 16:12:10 +0200	[thread overview]
Message-ID: <20200409141210.GA4673@ravnborg.org> (raw)
In-Reply-To: <20200409013947.12667-2-robh@kernel.org>

Hi Rob.

On Wed, Apr 08, 2020 at 07:39:45PM -0600, Rob Herring wrote:
> Add a missing MODULE_DEVICE_TABLE entry to fix module autoloading.
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Change looks straightforward.
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/drm/pl111/pl111_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index aa8aa8d9e405..7f405b1374c2 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -444,6 +444,7 @@ static const struct amba_id pl111_id_table[] = {
>  	},
>  	{0, 0},
>  };
> +MODULE_DEVICE_TABLE(amba, pl111_id_table);
>  
>  static struct amba_driver pl111_amba_driver __maybe_unused = {
>  	.drv = {
> -- 
> 2.20.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-09 14:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  1:39 [PATCH 0/3] drm: pl111: Fix module loading issues Rob Herring
2020-04-09  1:39 ` [PATCH 1/3] drm: pl111: Fix module autoloading Rob Herring
2020-04-09  1:39   ` Rob Herring
2020-04-09 14:12   ` Sam Ravnborg [this message]
2020-04-09 14:12     ` Sam Ravnborg
2020-04-17 20:09   ` Linus Walleij
2020-04-17 20:09     ` Linus Walleij
2020-04-09  1:39 ` [PATCH 2/3] drm: pl111: Simplify vexpress init Rob Herring
2020-04-09  1:39   ` Rob Herring
2020-04-09 14:16   ` Sam Ravnborg
2020-04-09 14:16     ` Sam Ravnborg
2020-04-17 17:43     ` Rob Herring
2020-04-17 17:43       ` Rob Herring
2020-04-17 20:23   ` Linus Walleij
2020-04-17 20:23     ` Linus Walleij
2020-04-09  1:39 ` [PATCH 3/3] drm: pl111: Move VExpress setup into versatile init Rob Herring
2020-04-09  1:39   ` Rob Herring
2020-04-09 14:34   ` Sam Ravnborg
2020-04-09 14:34     ` Sam Ravnborg
2020-04-17 17:33     ` Rob Herring
2020-04-17 17:33       ` Rob Herring
2020-04-17 20:27   ` Linus Walleij
2020-04-17 20:27     ` Linus Walleij
2020-04-19 17:12     ` Rob Herring
2020-04-19 17:12       ` Rob Herring
2020-04-17 20:28 ` [PATCH 0/3] drm: pl111: Fix module loading issues Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409141210.GA4673@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.