From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Stephan Gerhold <stephan@gerhold.net>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board
Date: Thu, 9 Apr 2020 16:32:43 +0200 [thread overview]
Message-ID: <20200409143243.GK389953@lunn.ch> (raw)
In-Reply-To: <20200409070448.3209-2-paweldembicki@gmail.com>
On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote:
> This patch adds dts for the Check Point L-50 from 600/1100 series
> routers.
Hi Pawel
Looks very good. Just a minor comment:
> +ð1 {
> + status = "okay";
> + ethernet1-port@0 {
> + speed = <1000>;
> + duplex = <1>;
> + };
> +};
This is a non-standard way of doing a fixed link. But looking at the
driver, that is all it supports. I also don't think it is worth the
effort converting it. Kirkwood is so old we hardly see any new boards
using it.
So:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Since we are in the merge window at the moment, this won't be merged
for a while.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <mripard@kernel.org>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Linus Walleij <linus.walleij@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board
Date: Thu, 9 Apr 2020 16:32:43 +0200 [thread overview]
Message-ID: <20200409143243.GK389953@lunn.ch> (raw)
In-Reply-To: <20200409070448.3209-2-paweldembicki@gmail.com>
On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote:
> This patch adds dts for the Check Point L-50 from 600/1100 series
> routers.
Hi Pawel
Looks very good. Just a minor comment:
> +ð1 {
> + status = "okay";
> + ethernet1-port@0 {
> + speed = <1000>;
> + duplex = <1>;
> + };
> +};
This is a non-standard way of doing a fixed link. But looking at the
driver, that is all it supports. I also don't think it is worth the
effort converting it. Kirkwood is so old we hardly see any new boards
using it.
So:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Since we are in the merge window at the moment, this won't be merged
for a while.
Andrew
next prev parent reply other threads:[~2020-04-09 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 7:04 [PATCH v2 1/2] dt-bindings: vendor-prefixes: Add Check Point Pawel Dembicki
2020-04-09 7:04 ` Pawel Dembicki
2020-04-09 7:04 ` [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board Pawel Dembicki
2020-04-09 7:04 ` Pawel Dembicki
2020-04-09 14:32 ` Andrew Lunn [this message]
2020-04-09 14:32 ` Andrew Lunn
2020-05-17 15:26 ` Gregory CLEMENT
2020-05-17 15:26 ` Gregory CLEMENT
2020-05-17 15:51 ` Paweł Dembicki
2020-05-17 15:51 ` Paweł Dembicki
2020-04-09 13:20 ` [PATCH v2 1/2] dt-bindings: vendor-prefixes: Add Check Point Sam Ravnborg
2020-04-09 13:20 ` Sam Ravnborg
2020-04-15 16:18 ` Rob Herring
2020-04-15 16:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409143243.GK389953@lunn.ch \
--to=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=paweldembicki@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.