From: Alexander A. Filippov <a.filippov@yadro.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC
Date: Fri, 10 Apr 2020 17:59:04 +0300 [thread overview]
Message-ID: <20200410145904.GA15615@bbwork.lan> (raw)
In-Reply-To: <ad46ff33-8ce2-4ffa-b12e-204053e4f705@www.fastmail.com>
On Fri, Apr 10, 2020 at 02:29:47PM +0930, Andrew Jeffery wrote:
>
>
> > +&i2c11 {
> > + status = "okay";
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > +};
>
> Are you accessing devices on the busses from userspace? It would
> be helpful to comment here why you're enabling all of these busses
> but not describing any devices on them, if it's necessary to enable
> them at all.
>
Yes, some of them are unused and may be removed.
For others I'll add comments in the next version.
> > +
> > +&adc {
> > + status = "okay";
>
> You should specify the pinmux configuration for the channels you're using
> to ensure exclusive access to those pins (otherwise they could be exported
> e.g. as GPIOs).
It was just copied from Romulus and looks like I missed iio-hwmon-battery.
Is it what you meant?
All other pins are wired to the ground.`
Alexander
WARNING: multiple messages have this Message-ID (diff)
From: "Alexander A. Filippov" <a.filippov@yadro.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC
Date: Fri, 10 Apr 2020 17:59:04 +0300 [thread overview]
Message-ID: <20200410145904.GA15615@bbwork.lan> (raw)
In-Reply-To: <ad46ff33-8ce2-4ffa-b12e-204053e4f705@www.fastmail.com>
On Fri, Apr 10, 2020 at 02:29:47PM +0930, Andrew Jeffery wrote:
>
>
> > +&i2c11 {
> > + status = "okay";
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > +};
>
> Are you accessing devices on the busses from userspace? It would
> be helpful to comment here why you're enabling all of these busses
> but not describing any devices on them, if it's necessary to enable
> them at all.
>
Yes, some of them are unused and may be removed.
For others I'll add comments in the next version.
> > +
> > +&adc {
> > + status = "okay";
>
> You should specify the pinmux configuration for the channels you're using
> to ensure exclusive access to those pins (otherwise they could be exported
> e.g. as GPIOs).
It was just copied from Romulus and looks like I missed iio-hwmon-battery.
Is it what you meant?
All other pins are wired to the ground.`
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Alexander A. Filippov" <a.filippov@yadro.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: <linux-aspeed@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC
Date: Fri, 10 Apr 2020 17:59:04 +0300 [thread overview]
Message-ID: <20200410145904.GA15615@bbwork.lan> (raw)
In-Reply-To: <ad46ff33-8ce2-4ffa-b12e-204053e4f705@www.fastmail.com>
On Fri, Apr 10, 2020 at 02:29:47PM +0930, Andrew Jeffery wrote:
>
>
> > +&i2c11 {
> > + status = "okay";
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > +};
>
> Are you accessing devices on the busses from userspace? It would
> be helpful to comment here why you're enabling all of these busses
> but not describing any devices on them, if it's necessary to enable
> them at all.
>
Yes, some of them are unused and may be removed.
For others I'll add comments in the next version.
> > +
> > +&adc {
> > + status = "okay";
>
> You should specify the pinmux configuration for the channels you're using
> to ensure exclusive access to those pins (otherwise they could be exported
> e.g. as GPIOs).
It was just copied from Romulus and looks like I missed iio-hwmon-battery.
Is it what you meant?
All other pins are wired to the ground.`
Alexander
next prev parent reply other threads:[~2020-04-10 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 10:15 [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC Alexander Filippov
2020-04-06 10:15 ` Alexander Filippov
2020-04-06 10:15 ` Alexander Filippov
2020-04-10 4:59 ` Andrew Jeffery
2020-04-10 4:59 ` Andrew Jeffery
2020-04-10 4:59 ` Andrew Jeffery
2020-04-10 14:59 ` Alexander A. Filippov [this message]
2020-04-10 14:59 ` Alexander A. Filippov
2020-04-10 14:59 ` Alexander A. Filippov
2020-04-16 3:56 ` Andrew Jeffery
2020-04-16 3:56 ` Andrew Jeffery
2020-04-16 3:56 ` Andrew Jeffery
-- strict thread matches above, loose matches on Subject: below --
2020-04-23 11:21 Alexander Filippov
2020-04-23 11:21 ` Alexander Filippov
2020-04-23 11:21 ` Alexander Filippov
2020-04-23 12:05 ` Alexander A. Filippov
2020-04-23 12:05 ` Alexander A. Filippov
2020-04-23 12:05 ` Alexander A. Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410145904.GA15615@bbwork.lan \
--to=a.filippov@yadro.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.