From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: boqun.feng@gmail.com,
QLogic-Storage-Upstream@qlogic.com (supporter:BROADCOM BNX2FC 10
GIGABIT FCOE DRIVER), "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org (open list:BROADCOM BNX2FC 10 GIGABIT
FCOE DRIVER)
Subject: [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup()
Date: Sat, 11 Apr 2020 01:19:31 +0100 [thread overview]
Message-ID: <20200411001933.10072-8-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200411001933.10072-1-jbi.octave@gmail.com>
Sparse reports a warning at bnx2fc_abts_cleanup()
warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock
The root cause is the missing annotation at bnx2fc_abts_cleanup()
Add the missing __must_hold(&tgt->tgt_lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index 4c8122a82322..b45f40db9379 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
@@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
}
static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
+ __must_hold(&tgt->tgt_lock)
{
struct bnx2fc_rport *tgt = io_req->tgt;
unsigned int time_left;
--
2.24.1
next prev parent reply other threads:[~2020-04-11 0:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/9>
2020-04-11 0:19 ` [PATCH 0/9] Lock warning cleanups Jules Irenge
2020-04-11 0:19 ` Jules Irenge
2020-04-11 0:19 ` Jules Irenge
2020-04-11 0:19 ` [PATCH 1/9] dm snapshot: Add missing annotation for dm_exception_table_lock() and dm_exception_table_unlock() Jules Irenge
2020-04-11 0:19 ` Jules Irenge
2020-04-11 0:19 ` [PATCH 2/9] mt76: remove unnecessary annotations Jules Irenge
2020-04-11 0:19 ` Jules Irenge
2020-04-11 0:19 ` Jules Irenge
2020-04-11 0:19 ` [PATCH 3/9] hostap: Add missing annotations for prism2_bss_list_proc_start() and prism2_bss_list_proc_stop Jules Irenge
2020-04-15 8:42 ` Kalle Valo
2020-04-11 0:19 ` [PATCH 4/9] mac80211: Add missing annotation for brcms_rfkill_set_hw_state() Jules Irenge
2020-04-15 8:44 ` [PATCH 4/9] brcmsmac: " Kalle Valo
2020-04-11 0:19 ` [PATCH 5/9] mac80211: Add missing annotation for brcms_down() Jules Irenge
2020-04-15 8:45 ` [PATCH 5/9] brcmsmac: " Kalle Valo
2020-04-11 0:19 ` [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() Jules Irenge
2020-04-14 7:35 ` John Garry
2020-04-15 1:44 ` Martin K. Petersen
2020-04-11 0:19 ` Jules Irenge [this message]
2020-04-24 16:56 ` [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() Martin K. Petersen
2020-04-11 0:19 ` [PATCH 8/9] power: wakeup: Add missing annotation for wakeup_sources_stats_seq_start() and wakeup_sources_stats_seq_stop() Jules Irenge
2020-04-11 0:19 ` [PATCH 9/9] power: wakeup: Add missing annotation for wakeup_sources_read_lock() and wakeup_sources_read_unlock() Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411001933.10072-8-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=boqun.feng@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.