From: Boris Brezillon <boris.brezillon@collabora.com>
To: Conor Culhane <conor.culhane@silvaco.com>
Cc: linux-i3c@lists.infradead.org, bbrezillon@kernel.org
Subject: Re: [PATCH] i3c: master: Add driver for Silvaco I3C Dual-Role Master IP
Date: Sat, 11 Apr 2020 14:09:47 +0200 [thread overview]
Message-ID: <20200411140947.58f674a9@collabora.com> (raw)
In-Reply-To: <20200411140353.16872a7f@collabora.com>
On Sat, 11 Apr 2020 14:03:53 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> Hi Connor,
>
> On Wed, 25 Mar 2020 12:00:47 -0400
> Conor Culhane <conor.culhane@silvaco.com> wrote:
>
> > This driver currently supports I3C SDR transfers. I3C HDR-DDR
> > transfer support may be added in the future.
> >
> > Signed-off-by: Conor Culhane <conor.culhane@silvaco.com>
> > ---
> > drivers/i3c/master/Kconfig | 8 +
> > drivers/i3c/master/Makefile | 3 +-
> > drivers/i3c/master/svc-i3c-master.c | 3801 +++++++++++++++++++++++++++
>
> Wow, almost 4k LoC for a driver supporting only SDR tranfers. Let's see
> if we can shrink that a bit.
Just a precision, I'd expect something between 1k and 2k lines of code
(see the 2 other drivers we have). Might be more than 2k if the IP is
complex, but at first glance that doesn't seem to be the case here.
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-04-11 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 16:00 [PATCH] i3c: master: Add driver for Silvaco I3C Dual-Role Master IP Conor Culhane
2020-04-11 12:03 ` Boris Brezillon
2020-04-11 12:09 ` Boris Brezillon [this message]
2020-04-11 20:38 ` Boris Brezillon
2020-04-16 19:47 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411140947.58f674a9@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.