From: Boris Brezillon <boris.brezillon@collabora.com>
To: Conor Culhane <conor.culhane@silvaco.com>
Cc: linux-i3c@lists.infradead.org, bbrezillon@kernel.org
Subject: Re: [PATCH] i3c: master: Add driver for Silvaco I3C Dual-Role Master IP
Date: Thu, 16 Apr 2020 21:47:59 +0200 [thread overview]
Message-ID: <20200416214759.464139ca@collabora.com> (raw)
In-Reply-To: <20200411223843.631c7710@collabora.com>
On Sat, 11 Apr 2020 22:38:43 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> +#define I3CS_CONFIG 0x004
> +#define I3CS_CONFIG_SLVENA BIT(0)
> +#define I3CS_CONFIG_NACK BIT(1)
> +#define I3CS_CONFIG_MATCHSS BIT(2)
> +#define I3CS_CONFIG_S0IGNORE BIT(3)
> +#define I3CS_CONFIG_DDROK BIT(4)
> +#define I3CS_CONFIG_IRAND BIT(8)
> +#define I3CS_CONFIG_BAMATCH(x) (((x) & GENMASK(7, 0)) << 16)
> +#define I3CS_CONFIG_SADDR(x) (((x) & GENMASK(6, 0)) << 25)
Just learned about the FIELD_{PREP,GET}() macros [1]. If you use them
you'll just have to define masks here.
[1]https://elixir.bootlin.com/linux/v5.7-rc1/source/include/linux/bitfield.h#L92
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2020-04-16 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 16:00 [PATCH] i3c: master: Add driver for Silvaco I3C Dual-Role Master IP Conor Culhane
2020-04-11 12:03 ` Boris Brezillon
2020-04-11 12:09 ` Boris Brezillon
2020-04-11 20:38 ` Boris Brezillon
2020-04-16 19:47 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416214759.464139ca@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.