From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: alexandru.ardelean@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, stefan.popa@analog.com,
knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: imu: adis: Add a missing '\n' in a log message
Date: Sun, 12 Apr 2020 10:00:28 +0000 [thread overview]
Message-ID: <20200412110005.79af5069@archlinux> (raw)
In-Reply-To: <20200410171224.4633-1-christophe.jaillet@wanadoo.fr>
On Fri, 10 Apr 2020 19:12:24 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Fixes: 1fd456702692 ("iio: imu: adis: add support product ID check in adis_initial_startup")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied thanks,
Jonathan
> ---
> drivers/iio/imu/adis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index a8afd01de4f3..2e7d0d337f8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -419,7 +419,7 @@ int __adis_initial_startup(struct adis *adis)
>
> if (prod_id != adis->data->prod_id)
> dev_warn(&adis->spi->dev,
> - "Device ID(%u) and product ID(%u) do not match.",
> + "Device ID(%u) and product ID(%u) do not match.\n",
> adis->data->prod_id, prod_id);
>
> return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: alexandru.ardelean@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, stefan.popa@analog.com,
knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: imu: adis: Add a missing '\n' in a log message
Date: Sun, 12 Apr 2020 11:00:28 +0100 [thread overview]
Message-ID: <20200412110005.79af5069@archlinux> (raw)
In-Reply-To: <20200410171224.4633-1-christophe.jaillet@wanadoo.fr>
On Fri, 10 Apr 2020 19:12:24 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Fixes: 1fd456702692 ("iio: imu: adis: add support product ID check in adis_initial_startup")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied thanks,
Jonathan
> ---
> drivers/iio/imu/adis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index a8afd01de4f3..2e7d0d337f8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -419,7 +419,7 @@ int __adis_initial_startup(struct adis *adis)
>
> if (prod_id != adis->data->prod_id)
> dev_warn(&adis->spi->dev,
> - "Device ID(%u) and product ID(%u) do not match.",
> + "Device ID(%u) and product ID(%u) do not match.\n",
> adis->data->prod_id, prod_id);
>
> return 0;
next prev parent reply other threads:[~2020-04-12 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 17:12 [PATCH] iio: imu: adis: Add a missing '\n' in a log message Christophe JAILLET
2020-04-10 17:12 ` Christophe JAILLET
2020-04-12 10:00 ` Jonathan Cameron [this message]
2020-04-12 10:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412110005.79af5069@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.