[PATCH 0/4] Assign a few generic tests to additional groups

[PATCH 0/4] Assign a few generic tests to additional groups

[Vladimir Zapolskiy]

The rationale behind the proposed changes is to correct and improve
granularity of some generic tests, so it becomes possible to control
lists of run tests better, if there is given additional information
about a test environment and tested filesystems.

Vladimir Zapolskiy (4):
  Add generic/459 test to freeze group of tests
  Add generic/482 test to thin group of tests
  Add generic/529 test to acl group of tests
  Add generic/530 test to shutdown group of tests

 tests/generic/group | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.25.1

[PATCH 1/4] Add generic/459 test to freeze group of tests

[Vladimir Zapolskiy]

If a filesystem does not support freeze feature, the generic/459 test
execution is not run due to a `_require_freeze' check in runtime.

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index 99d06c9ad945..8f02f02551cc 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -461,7 +461,7 @@
 456 auto quick metadata collapse zero prealloc
 457 auto log replay clone
 458 auto quick clone collapse zero
-459 auto thin
+459 auto freeze thin
 460 auto quick rw
 461 auto shutdown stress
 462 auto quick dax
-- 
2.25.1

[PATCH 2/4] Add generic/482 test to thin group of tests

[Vladimir Zapolskiy]

If a kernel is built with disabled CONFIG_DM_THIN_PROVISIONING option,
the generic/482 test execution is not run due to a check performed in
runtime, the dm-thin dependency has been added in commit 65cc9a235919.

    [not run] This test requires dm thin-pool support

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index 8f02f02551cc..15f4bb085493 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -484,7 +484,7 @@
 479 auto quick metadata log
 480 auto quick metadata log
 481 auto quick log metadata
-482 auto metadata replay
+482 auto metadata replay thin
 483 auto quick log metadata
 485 auto quick insert
 486 auto quick attr
-- 
2.25.1

[PATCH 3/4] Add generic/529 test to acl group of tests

[Vladimir Zapolskiy]

If a filesystem does not support ACLs, the generic/529 test
execution is not run due to a `_require_acls' check executed
in runtime.

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index 15f4bb085493..cad08e045001 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -530,7 +530,7 @@
 526 auto quick log
 527 auto quick log
 528 auto quick
-529 auto quick attr
+529 auto quick acl attr
 530 auto quick unlink
 531 auto quick unlink
 532 auto quick
-- 
2.25.1

[PATCH 4/4] Add generic/530 test to shutdown group of tests

[Vladimir Zapolskiy]

If a scratch filesystem does not support shutdown feature, the generic/530
test execution is not run due to a `_require_scratch_shutdown' check
executed in runtime.

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index cad08e045001..718575baeef9 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -531,7 +531,7 @@
 527 auto quick log
 528 auto quick
 529 auto quick acl attr
-530 auto quick unlink
+530 auto quick shutdown unlink
 531 auto quick unlink
 532 auto quick
 533 auto quick attr
-- 
2.25.1

Re: [PATCH 0/4] Assign a few generic tests to additional groups

[Zorro Lang]

On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
> The rationale behind the proposed changes is to correct and improve
> granularity of some generic tests, so it becomes possible to control
> lists of run tests better, if there is given additional information
> about a test environment and tested filesystems.
> 
> Vladimir Zapolskiy (4):
>   Add generic/459 test to freeze group of tests
>   Add generic/482 test to thin group of tests
>   Add generic/529 test to acl group of tests
>   Add generic/530 test to shutdown group of tests

That's fine for me, to set more sub-cases in proper groups. Due to generally
when someone writes a case, we don't take care of its group list so much.

> 
>  tests/generic/group | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
> 

Re: [PATCH 0/4] Assign a few generic tests to additional groups

[Eryu Guan]

On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
> The rationale behind the proposed changes is to correct and improve
> granularity of some generic tests, so it becomes possible to control
> lists of run tests better, if there is given additional information
> about a test environment and tested filesystems.

Thanks for doing this! I think we could group these changes in a single
patch. Could you please resend with a single patch that does all the
group changes?

Thanks,
Eryu

> 
> Vladimir Zapolskiy (4):
>   Add generic/459 test to freeze group of tests
>   Add generic/482 test to thin group of tests
>   Add generic/529 test to acl group of tests
>   Add generic/530 test to shutdown group of tests
> 
>  tests/generic/group | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.25.1
> 

Re: [PATCH 0/4] Assign a few generic tests to additional groups

[Vladimir Zapolskiy]

On 4/12/20 2:16 PM, Eryu Guan wrote:
> On Wed, Apr 08, 2020 at 04:56:44PM +0300, Vladimir Zapolskiy wrote:
>> The rationale behind the proposed changes is to correct and improve
>> granularity of some generic tests, so it becomes possible to control
>> lists of run tests better, if there is given additional information
>> about a test environment and tested filesystems.
> 
> Thanks for doing this! I think we could group these changes in a single
> patch. Could you please resend with a single patch that does all the
> group changes?

Sure, will do.

Thank you for review!

--
Best wishes,
Vladimir