From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Inki Dae <inki.dae@samsung.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v1 4/4] drm/bridge: tc358764: make connector creation optional
Date: Tue, 14 Apr 2020 10:47:27 +0200 [thread overview]
Message-ID: <20200414084727.8326-5-sam@ravnborg.org> (raw)
In-Reply-To: <20200414084727.8326-1-sam@ravnborg.org>
Make the connector creation optional to enable usage of the
tc358764 bridge with the DRM bridge connector helper.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
---
drivers/gpu/drm/bridge/tc358764.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
index a5abf15e5c7f..4ebabea86040 100644
--- a/drivers/gpu/drm/bridge/tc358764.c
+++ b/drivers/gpu/drm/bridge/tc358764.c
@@ -337,10 +337,8 @@ static int tc358764_attach(struct drm_bridge *bridge,
if (ret < 0)
return ret;
- if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
- DRM_ERROR("Fix bridge driver to make connector optional!");
- return -EINVAL;
- }
+ if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
+ return 0;
ctx->connector.polled = DRM_CONNECTOR_POLL_HPD;
ret = drm_connector_init(drm, &ctx->connector,
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-14 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 8:47 [PATCH v1 0/4] drm: tc358764: support drm bridge connector helper Sam Ravnborg
2020-04-14 8:47 ` [PATCH v1 1/4] drm/panel: add connector type to boe, hv070wsa-100 panel Sam Ravnborg
2020-04-14 9:32 ` Laurent Pinchart
2020-04-14 8:47 ` [PATCH v1 2/4] drm/bridge: tc358764: drop drm_connector_(un)register Sam Ravnborg
2020-04-14 9:33 ` Laurent Pinchart
2020-04-14 8:47 ` [PATCH v1 3/4] drm/bridge: tc358764: add drm_panel_bridge support Sam Ravnborg
2020-04-14 9:35 ` Laurent Pinchart
2020-04-14 8:47 ` Sam Ravnborg [this message]
2020-04-14 9:38 ` [PATCH v1 4/4] drm/bridge: tc358764: make connector creation optional Laurent Pinchart
2020-04-14 13:36 ` Sam Ravnborg
2020-04-14 13:41 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414084727.8326-5-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=narmstrong@baylibre.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.