Re: [PATCH v1 1/4] drm/panel: add connector type to boe, hv070wsa-100 panel

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v1 1/4] drm/panel: add connector type to boe, hv070wsa-100 panel
Date: Tue, 14 Apr 2020 12:32:33 +0300	[thread overview]
Message-ID: <20200414093233.GA19819@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200414084727.8326-2-sam@ravnborg.org>

Hi Sam,

Thank you for the patch.

On Tue, Apr 14, 2020 at 10:47:24AM +0200, Sam Ravnborg wrote:
> The boe,hv070wsa-100 panel is a LVDS panel.
> Fix connector type to reflect this.
> 
> With this change users of this panel do not have to specify the
> connector type.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 44a1f5dfb571..749115c98ee2 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1059,6 +1059,7 @@ static const struct panel_desc boe_hv070wsa = {
>  		.width = 154,
>  		.height = 90,
>  	},
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,

While at it, could you set .bus_format too ? It's particularly important
for LVDS panels.

>  };
>  
>  static const struct drm_display_mode boe_nv101wxmn51_modes[] = {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel