From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
balbi@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message
Date: Tue, 14 Apr 2020 09:31:18 +0000 [thread overview]
Message-ID: <20200414093118.GD1163@kadam> (raw)
In-Reply-To: <ZQKM8Q.561QQF8CXZTU3@crapouillou.net>
On Sat, Apr 11, 2020 at 03:13:47PM +0200, Paul Cercueil wrote:
> Hi Christophe,
>
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Is that so?
>
> From what I could see these macros add the \n themselves if needed. So the
> \n were omitted on purpose.
>
Do a "make drivers/usb/phy/phy-jz4770.i" and look at the string. The
patch is correct.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
balbi@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message
Date: Tue, 14 Apr 2020 12:31:18 +0300 [thread overview]
Message-ID: <20200414093118.GD1163@kadam> (raw)
In-Reply-To: <ZQKM8Q.561QQF8CXZTU3@crapouillou.net>
On Sat, Apr 11, 2020 at 03:13:47PM +0200, Paul Cercueil wrote:
> Hi Christophe,
>
> Le sam. 11 avril 2020 à 8:38, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> a écrit :
> > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
>
> Is that so?
>
> From what I could see these macros add the \n themselves if needed. So the
> \n were omitted on purpose.
>
Do a "make drivers/usb/phy/phy-jz4770.i" and look at the string. The
patch is correct.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-14 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 6:38 [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message Christophe JAILLET
2020-04-11 6:38 ` Christophe JAILLET
2020-04-11 13:13 ` Paul Cercueil
2020-04-11 13:13 ` Paul Cercueil
2020-04-11 15:46 ` Joe Perches
2020-04-11 15:46 ` Joe Perches
2020-04-14 9:31 ` Dan Carpenter [this message]
2020-04-14 9:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414093118.GD1163@kadam \
--to=dan.carpenter@oracle.com \
--cc=balbi@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.