* [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech,idk-2121wr
@ 2020-04-12 13:21 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-12 13:21 UTC (permalink / raw)
To: dri-devel, Thierry Reding, Rob Herring, devicetree
Cc: Fabrizio Castro, Lad Prabhakar, Sam Ravnborg
The binding for the advantech,idk-2121wr uses an example
where a ports {} node is used.
The panel-lvds binding failed to support a ports node,
which the following patch fixes.
This fix was part of a longer series, but we need this fix
in upstream before -rc2.
So pull this out of the larger series.
Sam
Sam Ravnborg (1):
dt-bindings: display: allow port and ports in panel-lvds
Documentation/devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech, idk-2121wr
@ 2020-04-12 13:21 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-12 13:21 UTC (permalink / raw)
To: dri-devel, Thierry Reding, Rob Herring, devicetree
Cc: Fabrizio Castro, Sam Ravnborg, Lad Prabhakar
The binding for the advantech,idk-2121wr uses an example
where a ports {} node is used.
The panel-lvds binding failed to support a ports node,
which the following patch fixes.
This fix was part of a longer series, but we need this fix
in upstream before -rc2.
So pull this out of the larger series.
Sam
Sam Ravnborg (1):
dt-bindings: display: allow port and ports in panel-lvds
Documentation/devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
2020-04-12 13:21 ` [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech, idk-2121wr Sam Ravnborg
@ 2020-04-12 13:21 ` Sam Ravnborg
-1 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-12 13:21 UTC (permalink / raw)
To: dri-devel, Thierry Reding, Rob Herring, devicetree
Cc: Fabrizio Castro, Lad Prabhakar, Sam Ravnborg
Both port and ports names may be used in a panel-lvds binding
port - for a single port
ports - if there is more than one port in sub-nodes
Fixes the following warning:
advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property
advantech,idk-2121wr.yaml needs several ports, so uses a ports node.
v2:
- Use oneOf - makes the logic more obvious (Rob)
- Added Fixes tag
- Added port: true, ports:true
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Herring <robh@kernel.org>
Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
---
.../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
index d0083301acbe..a5587c4f5ad0 100644
--- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
@@ -96,12 +96,20 @@ properties:
If set, reverse the bit order described in the data mappings below on all
data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
+ port: true
+ ports: true
+
required:
- compatible
- data-mapping
- width-mm
- height-mm
- panel-timing
- - port
+
+oneOf:
+ - required:
+ - port
+ - required:
+ - ports
...
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
@ 2020-04-12 13:21 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-12 13:21 UTC (permalink / raw)
To: dri-devel, Thierry Reding, Rob Herring, devicetree
Cc: Fabrizio Castro, Sam Ravnborg, Lad Prabhakar
Both port and ports names may be used in a panel-lvds binding
port - for a single port
ports - if there is more than one port in sub-nodes
Fixes the following warning:
advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property
advantech,idk-2121wr.yaml needs several ports, so uses a ports node.
v2:
- Use oneOf - makes the logic more obvious (Rob)
- Added Fixes tag
- Added port: true, ports:true
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Herring <robh@kernel.org>
Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
---
.../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
index d0083301acbe..a5587c4f5ad0 100644
--- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
@@ -96,12 +96,20 @@ properties:
If set, reverse the bit order described in the data mappings below on all
data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
+ port: true
+ ports: true
+
required:
- compatible
- data-mapping
- width-mm
- height-mm
- panel-timing
- - port
+
+oneOf:
+ - required:
+ - port
+ - required:
+ - ports
...
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
2020-04-12 13:21 ` Sam Ravnborg
@ 2020-04-14 13:55 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-04-14 13:55 UTC (permalink / raw)
To: Sam Ravnborg
Cc: dri-devel, Thierry Reding, devicetree, Fabrizio Castro,
Lad Prabhakar
On Sun, Apr 12, 2020 at 03:21:39PM +0200, Sam Ravnborg wrote:
> Both port and ports names may be used in a panel-lvds binding
> port - for a single port
> ports - if there is more than one port in sub-nodes
>
> Fixes the following warning:
> advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property
>
> advantech,idk-2121wr.yaml needs several ports, so uses a ports node.
>
> v2:
> - Use oneOf - makes the logic more obvious (Rob)
> - Added Fixes tag
> - Added port: true, ports:true
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Rob Herring <robh@kernel.org>
> Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
One nit below...
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index d0083301acbe..a5587c4f5ad0 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -96,12 +96,20 @@ properties:
> If set, reverse the bit order described in the data mappings below on all
> data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
>
> + port: true
> + ports: true
> +
> required:
> - compatible
> - data-mapping
> - width-mm
> - height-mm
> - panel-timing
> - - port
> +
> +oneOf:
> + - required:
> + - port
> + - required:
> + - ports
Should be indented 2 more spaces. It only matters for any scripted
processing we do on the files.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
@ 2020-04-14 13:55 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-04-14 13:55 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Fabrizio Castro, devicetree, Thierry Reding, Lad Prabhakar,
dri-devel
On Sun, Apr 12, 2020 at 03:21:39PM +0200, Sam Ravnborg wrote:
> Both port and ports names may be used in a panel-lvds binding
> port - for a single port
> ports - if there is more than one port in sub-nodes
>
> Fixes the following warning:
> advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property
>
> advantech,idk-2121wr.yaml needs several ports, so uses a ports node.
>
> v2:
> - Use oneOf - makes the logic more obvious (Rob)
> - Added Fixes tag
> - Added port: true, ports:true
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Rob Herring <robh@kernel.org>
> Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
One nit below...
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index d0083301acbe..a5587c4f5ad0 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -96,12 +96,20 @@ properties:
> If set, reverse the bit order described in the data mappings below on all
> data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
>
> + port: true
> + ports: true
> +
> required:
> - compatible
> - data-mapping
> - width-mm
> - height-mm
> - panel-timing
> - - port
> +
> +oneOf:
> + - required:
> + - port
> + - required:
> + - ports
Should be indented 2 more spaces. It only matters for any scripted
processing we do on the files.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
2020-04-14 13:55 ` Rob Herring
@ 2020-04-14 16:24 ` Sam Ravnborg
-1 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-14 16:24 UTC (permalink / raw)
To: Rob Herring
Cc: dri-devel, Thierry Reding, devicetree, Fabrizio Castro,
Lad Prabhakar
Hi Rob.
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> One nit below...
>
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > index d0083301acbe..a5587c4f5ad0 100644
> > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > @@ -96,12 +96,20 @@ properties:
> > If set, reverse the bit order described in the data mappings below on all
> > data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
> >
> > + port: true
> > + ports: true
> > +
> > required:
> > - compatible
> > - data-mapping
> > - width-mm
> > - height-mm
> > - panel-timing
> > - - port
> > +
> > +oneOf:
> > + - required:
> > + - port
> > + - required:
> > + - ports
>
> Should be indented 2 more spaces. It only matters for any scripted
> processing we do on the files.
Fixed and pushed to drm-misc-next.
Will cherry-pick to drm-fixes.
Sam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
@ 2020-04-14 16:24 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-04-14 16:24 UTC (permalink / raw)
To: Rob Herring
Cc: Fabrizio Castro, devicetree, Thierry Reding, Lad Prabhakar,
dri-devel
Hi Rob.
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> One nit below...
>
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > index d0083301acbe..a5587c4f5ad0 100644
> > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > @@ -96,12 +96,20 @@ properties:
> > If set, reverse the bit order described in the data mappings below on all
> > data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
> >
> > + port: true
> > + ports: true
> > +
> > required:
> > - compatible
> > - data-mapping
> > - width-mm
> > - height-mm
> > - panel-timing
> > - - port
> > +
> > +oneOf:
> > + - required:
> > + - port
> > + - required:
> > + - ports
>
> Should be indented 2 more spaces. It only matters for any scripted
> processing we do on the files.
Fixed and pushed to drm-misc-next.
Will cherry-pick to drm-fixes.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-14 16:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-12 13:21 [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech,idk-2121wr Sam Ravnborg
2020-04-12 13:21 ` [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech, idk-2121wr Sam Ravnborg
2020-04-12 13:21 ` [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds Sam Ravnborg
2020-04-12 13:21 ` Sam Ravnborg
2020-04-14 13:55 ` Rob Herring
2020-04-14 13:55 ` Rob Herring
2020-04-14 16:24 ` Sam Ravnborg
2020-04-14 16:24 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.