Re: [PATCH v2 06/36] dt-bindings: display: convert boe,himax8279d to DT Schema

[Rob Herring <robh@kernel.org>]

On Wed, Apr 08, 2020 at 09:50:39PM +0200, Sam Ravnborg wrote:
> v2:
>   - Fix entry in MAINTAINERS
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../bindings/display/panel/boe,himax8279d.txt | 24 --------
>  .../display/panel/boe,himax8279d.yaml         | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 60 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> deleted file mode 100644
> index 3caea2172b1b..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Boe Himax8279d 1200x1920 TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10p"
> -- reg: DSI virtual channel of the peripheral
> -- enable-gpios: panel enable gpio
> -- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply voltage
> -- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> -	&mipi_dsi {
> -		panel {
> -			compatible = "boe,himax8279d8p", "boe,himax8279d10p";
> -			reg = <0>;
> -			backlight = <&backlight>;
> -			enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> -			pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> -			pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
> new file mode 100644
> index 000000000000..e42b6a8ae176
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/boe,himax8279d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Boe Himax8279d 1200x1920 TFT LCD panel
> +
> +maintainers:
> +  - Jerry Han <jerry.han.hq@gmail.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: boe,himax8279d8p
> +      - const: boe,himax8279d10p
> +
> +  backlight: true
> +  enable-gpios: true
> +  reg: true
> +
> +  pp33-gpios:
> +    maxItems: 1
> +    description: GPIO for the 3.3v pin that provides the supply voltage
> +
> +  pp18-gpios:
> +    maxItems: 1
> +    description: GPIO for the 1.8v pin that provides the supply voltage
> +
> +required:
> +  - compatible
> +  - reg
> +  - enable-gpios
> +  - pp33-gpios
> +  - pp18-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        panel {

panel@0

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

Double check the others. I won't repeat myself.

> +            compatible = "boe,himax8279d8p", "boe,himax8279d10p";
> +            reg = <0>;
> +            backlight = <&backlight>;
> +            enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> +            pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> +            pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b99fa16ba08..dba84e7726b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5255,7 +5255,7 @@ DRM DRIVER FOR BOE HIMAX8279D PANELS
>  M:	Jerry Han <hanxu5@huaqin.corp-partner.google.com>
>  S:	Maintained
>  F:	drivers/gpu/drm/panel/panel-boe-himax8279d.c
> -F:	Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +F:	Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
>  
>  DRM DRIVER FOR FARADAY TVE200 TV ENCODER
>  M:	Linus Walleij <linus.walleij@linaro.org>
> -- 
> 2.20.1
>