From: Chris Down <chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org>
To: svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vinmenon-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Leonid Moiseichuk
<lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
Subject: Re: [PATCH 1/2] memcg: expose vmpressure knobs
Date: Tue, 14 Apr 2020 23:55:25 +0100 [thread overview]
Message-ID: <20200414225525.GA1892067@chrisdown.name> (raw)
In-Reply-To: <20200413215750.7239-2-lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org writes:
>From: Leonid Moiseichuk <lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
>
>Populating memcg vmpressure controls with legacy defaults:
>- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16)
>- memory.pressure_level_critical_prio (3)
>- memory.pressure_level_medium (60)
>- memory.pressure_level_critical (95)
>
>Signed-off-by: Leonid Moiseichuk <lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
I'm against this even in the abstract, cgroup v1 is deprecated and its
interface frozen, and vmpressure is pretty much already supplanted by PSI,
which actually works (whereas vmpressure often doesn't since it mostly ends up
just measuring reclaim efficiency, rather than actual memory pressure).
Without an extremely compelling reason to expose these, this just muddles the
situation.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Down <chris@chrisdown.name>
To: svc_lmoiseichuk@magicleap.com
Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org,
akpm@linux-foundation.org, rientjes@google.com,
minchan@kernel.org, vinmenon@codeaurora.org,
andriy.shevchenko@linux.intel.com, anton.vorontsov@linaro.org,
penberg@kernel.org, linux-mm@kvack.org,
Leonid Moiseichuk <lmoiseichuk@magicleap.com>
Subject: Re: [PATCH 1/2] memcg: expose vmpressure knobs
Date: Tue, 14 Apr 2020 23:55:25 +0100 [thread overview]
Message-ID: <20200414225525.GA1892067@chrisdown.name> (raw)
In-Reply-To: <20200413215750.7239-2-lmoiseichuk@magicleap.com>
svc_lmoiseichuk@magicleap.com writes:
>From: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
>
>Populating memcg vmpressure controls with legacy defaults:
>- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16)
>- memory.pressure_level_critical_prio (3)
>- memory.pressure_level_medium (60)
>- memory.pressure_level_critical (95)
>
>Signed-off-by: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
I'm against this even in the abstract, cgroup v1 is deprecated and its
interface frozen, and vmpressure is pretty much already supplanted by PSI,
which actually works (whereas vmpressure often doesn't since it mostly ends up
just measuring reclaim efficiency, rather than actual memory pressure).
Without an extremely compelling reason to expose these, this just muddles the
situation.
next prev parent reply other threads:[~2020-04-14 22:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:57 [PATCH 0/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA
2020-04-13 21:57 ` svc_lmoiseichuk
[not found] ` <20200413215750.7239-1-lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
2020-04-13 21:57 ` [PATCH 1/2] memcg: expose vmpressure knobs svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA
2020-04-13 21:57 ` svc_lmoiseichuk
[not found] ` <20200413215750.7239-2-lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org>
2020-04-14 22:55 ` Chris Down [this message]
2020-04-14 22:55 ` Chris Down
2020-04-14 23:00 ` Leonid Moiseichuk
2020-04-13 21:57 ` [PATCH 2/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA
2020-04-13 21:57 ` svc_lmoiseichuk
2020-04-14 11:37 ` [PATCH 0/2] " Michal Hocko
2020-04-14 11:37 ` Michal Hocko
2020-04-14 16:42 ` Leonid Moiseichuk
[not found] ` <CAELvCDTGnpA4WBAMZjGSLTrg2-Dbb3kTmLjMTw_JLYXBdvpcxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-14 18:49 ` Michal Hocko
2020-04-14 18:49 ` Michal Hocko
2020-04-14 20:53 ` Leonid Moiseichuk
[not found] ` <CAELvCDQRYmTZrGSwBUjnRJB3kfB_5JOJ5ELdGv+tkCyhvM=x9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-15 7:51 ` Michal Hocko
2020-04-15 7:51 ` Michal Hocko
2020-04-15 12:17 ` Leonid Moiseichuk
[not found] ` <CAELvCDRpVi4zjpHCw1oeY=GXf8XO2TXGUFAwztvydS27Q8L9Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-15 12:28 ` Michal Hocko
2020-04-15 12:28 ` Michal Hocko
2020-04-15 12:33 ` Leonid Moiseichuk
2020-04-14 19:23 ` Johannes Weiner
2020-04-14 19:23 ` Johannes Weiner
2020-04-14 22:12 ` Leonid Moiseichuk
[not found] ` <CAELvCDS_z-bTvRZ7fxkfHjnjV1WzFcxarzrbT1pDwkXX_dmOoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-15 7:55 ` Michal Hocko
2020-04-15 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414225525.GA1892067@chrisdown.name \
--to=chris-6bi1550ioqenzz6mram98g@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=svc_lmoiseichuk-baZASSJvGmz3oGB3hsPCZA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vinmenon-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.