From: Kees Cook <keescook@chromium.org>
To: kbuild-all@lists.01.org
Subject: Re: [chrome-os:chromeos-4.19 21350/21402] drivers/misc/echo/echo.c:384:27: error: equality comparison with extraneous parentheses
Date: Wed, 15 Apr 2020 11:08:07 -0700 [thread overview]
Message-ID: <202004151103.B419F67@keescook> (raw)
In-Reply-To: <CAKwvOdnOuMcjzsqTt2aVtoiKN3L9zOONGX-4BJgRWedeWspWTA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Wed, Apr 15, 2020 at 10:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> `git describe --contains "$tag" | sed 's/~.*//'` is my trick for
> finding the first tag that contained a commit.
BTW, this might be a useful tweak: since I have so many tags in my tree
beyond just Linus's tags (e.g. from linux-next), I also include "--match
'v*'". My ~/bin/git-contains is:
git describe --match 'v*' --contains "$1" | cut -d~ -f1 | cut -d^ -f1
(without this, my "git contains 85dc2c65e6c9" would report "next-20180927")
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Guenter Roeck <groeck@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
kbuild test robot <lkp@intel.com>,
cros-kernel-buildreports@googlegroups.com,
kbuild-all@lists.01.org,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [chrome-os:chromeos-4.19 21350/21402] drivers/misc/echo/echo.c:384:27: error: equality comparison with extraneous parentheses
Date: Wed, 15 Apr 2020 11:08:07 -0700 [thread overview]
Message-ID: <202004151103.B419F67@keescook> (raw)
In-Reply-To: <CAKwvOdnOuMcjzsqTt2aVtoiKN3L9zOONGX-4BJgRWedeWspWTA@mail.gmail.com>
On Wed, Apr 15, 2020 at 10:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> `git describe --contains "$tag" | sed 's/~.*//'` is my trick for
> finding the first tag that contained a commit.
BTW, this might be a useful tweak: since I have so many tags in my tree
beyond just Linus's tags (e.g. from linux-next), I also include "--match
'v*'". My ~/bin/git-contains is:
git describe --match 'v*' --contains "$1" | cut -d~ -f1 | cut -d^ -f1
(without this, my "git contains 85dc2c65e6c9" would report "next-20180927")
--
Kees Cook
next prev parent reply other threads:[~2020-04-15 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 22:09 [chrome-os:chromeos-4.19 21350/21402] drivers/misc/echo/echo.c:384:27: error: equality comparison with extraneous parentheses kbuild test robot
[not found] ` <20200415002618.GB19509@ubuntu-s3-xlarge-x86>
2020-04-15 0:56 ` Guenter Roeck
2020-04-15 17:51 ` Nick Desaulniers
2020-04-15 17:51 ` Nick Desaulniers
2020-04-15 18:08 ` Kees Cook [this message]
2020-04-15 18:08 ` Kees Cook
2020-04-16 3:31 ` Sasha Levin
2020-04-16 3:31 ` Sasha Levin
2020-04-16 3:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004151103.B419F67@keescook \
--to=keescook@chromium.org \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.