From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v1 1/2] i2c: designware: Make master module optional
Date: Wed, 15 Apr 2020 13:37:20 +0200 [thread overview]
Message-ID: <20200415113720.GA910@ninjato> (raw)
In-Reply-To: <20200325114529.GU1922688@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
> > Size of i2c-designware-core.ko is around 12 kB with all master, slave and
> > Baytrail semaphore code built in so I don't think it justifies the added
> > config complexity. I think distributions will have anyway all of those
> > options set.
>
> I would rather go with conditional based on I²C generic options, like I2C_SLAVE.
> Do we have something similar for master?
No, we don't have that.
>
> > Having those code in separate modules and load only when needed might make
> > sense as that would save a few kB of RAM.
>
> ...which makes sense for embedded systems where exactly the device represents
> I²C slave.
Frankly: an I2C-slave-only embedded system which runs a modern Linux and
cannot afford those few KB on a core feature it needs? If so, maybe it
should have an out-of-tree patch to achieve this. I don't think it is
worth the added complexity for the upstream version.
Sidenote: There is a lot more overhead in the i2c-core. I think the
complexity to move out stuff there is even more messy.
Disclaimer: you may prove me wrong, of course :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-04-15 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 10:04 [PATCH v1 1/2] i2c: designware: Make master module optional Andy Shevchenko
2020-03-23 10:04 ` [PATCH v1 2/2] i2c: designware: Move configuration routines to respective modules Andy Shevchenko
2020-03-23 12:26 ` [PATCH v1 1/2] i2c: designware: Make master module optional Andy Shevchenko
2020-03-25 7:47 ` Jarkko Nikula
2020-03-25 11:45 ` Andy Shevchenko
2020-04-15 11:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415113720.GA910@ninjato \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.