Re: [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings

[Rob Herring <robh@kernel.org>]

On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote:
> Add Display Port HPD GPIO description in bindings
> 
> This Patch depends on:
> 	https://patchwork.kernel.org/patch/11468505/

This belongs below the '---' and probably means you should send all this 
as one series.

> 
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
> index 761a01d..003f5f7 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
> @@ -155,6 +155,11 @@ properties:
>       data-lanes:
>         description: Maximum number of lanes that can be used for Display port.
>  
> +     dp-hpd-gpio:

We already have a standard property for this. Use it. 

It belongs in the connector node as HPD is part of the connector.

> +       maxItems: 1
> +       description: Specifies HPD gpio for DP connector without
> +                    USB PHY or AUX switch.
> +
>       usbplug-cc-gpio:

Note that this too should be in a connector node.

>         maxItems: 1
>         description: Specifies the usbplug orientation gpio.
> @@ -282,6 +287,8 @@ examples:
>          aux-sel-gpio = <&msmgpio 110 1>;
>          usbplug-cc-gpio = <&msmgpio 90 1>;
>  
> +        dp-hpd-gpio = <&msmgpio 117 0>;
> +
>          ports {
>              #address-cells = <1>;
>              #size-cells = <0>;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project