From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Felipe Balbi <balbi@kernel.org>,
amd-gfx@lists.freedesktop.org,
"Michael S. Tsirkin" <mst@redhat.com>,
intel-gvt-dev@lists.freedesktop.org,
Felix Kuehling <Felix.Kuehling@amd.com>,
linux-usb@vger.kernel.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhenyu Wang <zhenyuw@linux.intel.com>,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
intel-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jason Wang <jasowang@redhat.com>, Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH 3/3] kernel: set USER_DS in kthread_use_mm
Date: Thu, 16 Apr 2020 08:43:11 +0200 [thread overview]
Message-ID: <20200416064311.GA300290@kroah.com> (raw)
In-Reply-To: <20200416053158.586887-4-hch@lst.de>
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote:
> Some architectures like arm64 and s390 require USER_DS to be set for
> kernel threads to access user address space, which is the whole purpose
> of kthread_use_mm, but other like x86 don't. That has lead to a huge
> mess where some callers are fixed up once they are tested on said
> architectures, while others linger around and yet other like io_uring
> try to do "clever" optimizations for what usually is just a trivial
> asignment to a member in the thread_struct for most architectures.
>
> Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the
> previous value instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Michael S. Tsirkin <mst@redhat.com> [vhost]
> ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [usb]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>, Felipe Balbi <balbi@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 3/3] kernel: set USER_DS in kthread_use_mm
Date: Thu, 16 Apr 2020 08:43:11 +0200 [thread overview]
Message-ID: <20200416064311.GA300290@kroah.com> (raw)
In-Reply-To: <20200416053158.586887-4-hch@lst.de>
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote:
> Some architectures like arm64 and s390 require USER_DS to be set for
> kernel threads to access user address space, which is the whole purpose
> of kthread_use_mm, but other like x86 don't. That has lead to a huge
> mess where some callers are fixed up once they are tested on said
> architectures, while others linger around and yet other like io_uring
> try to do "clever" optimizations for what usually is just a trivial
> asignment to a member in the thread_struct for most architectures.
>
> Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the
> previous value instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Michael S. Tsirkin <mst@redhat.com> [vhost]
> ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [usb]
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Felipe Balbi <balbi@kernel.org>,
amd-gfx@lists.freedesktop.org,
"Michael S. Tsirkin" <mst@redhat.com>,
intel-gvt-dev@lists.freedesktop.org,
Felix Kuehling <Felix.Kuehling@amd.com>,
linux-usb@vger.kernel.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
intel-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 3/3] kernel: set USER_DS in kthread_use_mm
Date: Thu, 16 Apr 2020 08:43:11 +0200 [thread overview]
Message-ID: <20200416064311.GA300290@kroah.com> (raw)
In-Reply-To: <20200416053158.586887-4-hch@lst.de>
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote:
> Some architectures like arm64 and s390 require USER_DS to be set for
> kernel threads to access user address space, which is the whole purpose
> of kthread_use_mm, but other like x86 don't. That has lead to a huge
> mess where some callers are fixed up once they are tested on said
> architectures, while others linger around and yet other like io_uring
> try to do "clever" optimizations for what usually is just a trivial
> asignment to a member in the thread_struct for most architectures.
>
> Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the
> previous value instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Michael S. Tsirkin <mst@redhat.com> [vhost]
> ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [usb]
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Felipe Balbi <balbi@kernel.org>,
amd-gfx@lists.freedesktop.org,
"Michael S. Tsirkin" <mst@redhat.com>,
intel-gvt-dev@lists.freedesktop.org,
Felix Kuehling <Felix.Kuehling@amd.com>,
linux-usb@vger.kernel.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
intel-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 3/3] kernel: set USER_DS in kthread_use_mm
Date: Thu, 16 Apr 2020 08:43:11 +0200 [thread overview]
Message-ID: <20200416064311.GA300290@kroah.com> (raw)
In-Reply-To: <20200416053158.586887-4-hch@lst.de>
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote:
> Some architectures like arm64 and s390 require USER_DS to be set for
> kernel threads to access user address space, which is the whole purpose
> of kthread_use_mm, but other like x86 don't. That has lead to a huge
> mess where some callers are fixed up once they are tested on said
> architectures, while others linger around and yet other like io_uring
> try to do "clever" optimizations for what usually is just a trivial
> asignment to a member in the thread_struct for most architectures.
>
> Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the
> previous value instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Michael S. Tsirkin <mst@redhat.com> [vhost]
> ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [usb]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-16 7:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 5:31 improve use_mm / unuse_mm v2 Christoph Hellwig
2020-04-16 5:31 ` [Intel-gfx] " Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 5:31 ` [PATCH 1/3] kernel: move use_mm/unuse_mm to kthread.c Christoph Hellwig
2020-04-16 5:31 ` [Intel-gfx] " Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 5:31 ` [PATCH 2/3] kernel: better document the use_mm/unuse_mm API contract Christoph Hellwig
2020-04-16 5:31 ` [Intel-gfx] " Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 6:43 ` Greg KH
2020-04-16 6:43 ` [Intel-gfx] " Greg KH
2020-04-16 6:43 ` Greg KH
2020-04-16 6:43 ` Greg KH
2020-04-16 5:31 ` [PATCH 3/3] kernel: set USER_DS in kthread_use_mm Christoph Hellwig
2020-04-16 5:31 ` [Intel-gfx] " Christoph Hellwig
2020-04-16 5:31 ` Christoph Hellwig
2020-04-16 6:43 ` Greg KH [this message]
2020-04-16 6:43 ` [Intel-gfx] " Greg KH
2020-04-16 6:43 ` Greg KH
2020-04-16 6:43 ` Greg KH
2020-04-16 6:56 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] kernel: move use_mm/unuse_mm to kthread.c Patchwork
2020-04-17 3:17 ` improve use_mm / unuse_mm v2 Matthew Wilcox
2020-04-17 3:17 ` [Intel-gfx] " Matthew Wilcox
2020-04-17 3:17 ` Matthew Wilcox
2020-04-17 6:31 ` Christoph Hellwig
2020-04-17 6:31 ` [Intel-gfx] " Christoph Hellwig
2020-04-17 6:31 ` Christoph Hellwig
2020-04-17 14:25 ` Jens Axboe
2020-04-17 14:25 ` [Intel-gfx] " Jens Axboe
2020-04-17 14:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416064311.GA300290@kroah.com \
--to=greg@kroah.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=io-uring@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=mst@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.