Re: FAILED: patch "[PATCH] drm: Remove PageReserved manipulation from drm_pci_alloc" failed to apply to 4.19-stable tree

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Apr 15, 2020 at 10:31:21PM -0400, Sasha Levin wrote:
> On Wed, Apr 15, 2020 at 01:32:50PM +0200, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 4.19-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > > From ea36ec8623f56791c6ff6738d0509b7920f85220 Mon Sep 17 00:00:00 2001
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Sun, 2 Feb 2020 17:16:31 +0000
> > Subject: [PATCH] drm: Remove PageReserved manipulation from drm_pci_alloc
> > 
> > drm_pci_alloc/drm_pci_free are very thin wrappers around the core dma
> > facilities, and we have no special reason within the drm layer to behave
> > differently. In particular, since
> > 
> > commit de09d31dd38a50fdce106c15abd68432eebbd014
> > Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Date:   Fri Jan 15 16:51:42 2016 -0800
> > 
> >    page-flags: define PG_reserved behavior on compound pages
> > 
> >    As far as I can see there's no users of PG_reserved on compound pages.
> >    Let's use PF_NO_COMPOUND here.
> > 
> > it has been illegal to combine GFP_COMP with SetPageReserved, so lets
> > stop doing both and leave the dma layer to its own devices.
> > 
> > Reported-by: Taketo Kabe
> > Bug: https://gitlab.freedesktop.org/drm/intel/issues/1027
> > Fixes: de09d31dd38a ("page-flags: define PG_reserved behavior on compound pages")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: <stable@vger.kernel.org> # v4.5+
> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > Link: https://patchwork.freedesktop.org/patch/msgid/20200202171635.4039044-1-chris@chris-wilson.co.uk
> 
> We didn't have 750afb08ca71 ("cross-tree: phase out
> dma_zalloc_coherent()") on older kernels. Fixed and queued up.

Thanks for this, and all the other FAILED: fixes as well.

greg k-h