From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org
Subject: Re: linux-next: Tree for Apr 15 (vdpa)
Date: Thu, 16 Apr 2020 08:32:24 -0400 [thread overview]
Message-ID: <20200416082248-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <33e4922f-d2b5-f3fa-4d32-a5db5a177238@redhat.com>
On Thu, Apr 16, 2020 at 12:07:06PM +0800, Jason Wang wrote:
>
> On 2020/4/16 上午12:16, Randy Dunlap wrote:
> > On 4/14/20 10:22 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20200414:
> > >
> > on x86_64:
> >
> > ERROR: modpost: "vringh_set_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_init_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_push_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_pull_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_complete_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_getdesc_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >
> >
> > Full randconfig file is attached.
> >
>
> The config has
>
> CONFIG_VHOST_IOTLB=m
> CONFIG_VHOST_RING=y
>
> But we don't select VHOST_IOTLB in VHOST_RING after commit
> e6faeaa128417("vhost: drop vring dependency on iotlb"). Which seems wrong.
>
> Thanks
Well selecting IOTLB from ring breaks configs which don't need IOTLB.
Legal configurations are:
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=y
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=y
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=m
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=m
CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=m
So VHOST_RING=y and VHOST_IOTLB=m is the only illegal one.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>,
virtualization@lists.linux-foundation.org,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Apr 15 (vdpa)
Date: Thu, 16 Apr 2020 08:32:24 -0400 [thread overview]
Message-ID: <20200416082248-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <33e4922f-d2b5-f3fa-4d32-a5db5a177238@redhat.com>
On Thu, Apr 16, 2020 at 12:07:06PM +0800, Jason Wang wrote:
>
> On 2020/4/16 上午12:16, Randy Dunlap wrote:
> > On 4/14/20 10:22 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20200414:
> > >
> > on x86_64:
> >
> > ERROR: modpost: "vringh_set_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_init_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_push_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_pull_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_complete_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_getdesc_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >
> >
> > Full randconfig file is attached.
> >
>
> The config has
>
> CONFIG_VHOST_IOTLB=m
> CONFIG_VHOST_RING=y
>
> But we don't select VHOST_IOTLB in VHOST_RING after commit
> e6faeaa128417("vhost: drop vring dependency on iotlb"). Which seems wrong.
>
> Thanks
Well selecting IOTLB from ring breaks configs which don't need IOTLB.
Legal configurations are:
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=n
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=y
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=y
CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=m
CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=m
CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=m
So VHOST_RING=y and VHOST_IOTLB=m is the only illegal one.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-04-16 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 5:22 linux-next: Tree for Apr 15 Stephen Rothwell
2020-04-15 15:39 ` linux-next: Tree for Apr 15 (MEDIA Kconfig symbols) Randy Dunlap
2020-04-15 16:01 ` Mauro Carvalho Chehab
2020-04-15 15:41 ` linux-next: Tree for Apr 15 (MEDIA Kconfig symbols #2) Randy Dunlap
2020-04-15 16:16 ` linux-next: Tree for Apr 15 (vdpa) Randy Dunlap
2020-04-16 4:07 ` Jason Wang
2020-04-16 4:07 ` Jason Wang
2020-04-16 12:32 ` Michael S. Tsirkin [this message]
2020-04-16 12:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416082248-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.