From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: rajmohan.mani@intel.com, bingbu.cao@intel.com, tfiga@chromium.org
Subject: [PATCH 0/3] IPU3 ImgU driver parameter struct fixes
Date: Thu, 16 Apr 2020 12:18:47 +0300 [thread overview]
Message-ID: <20200416091850.31177-1-sakari.ailus@linux.intel.com> (raw)
Hi all,
This set addresses parameter struct memory layout changes introduced by
seemingly innocent patches, and adds a sanity check for the struct size to
avoid this from happening again. This only touches the uAPI, not the
ipu3-abi.h that deals with ABI not visible in the driver uAPI. That should
be addressed as well going forward.
The first patch does not probably entirely fix the issues, but with the
second patch added, pahole agrees the struct memory layout is unchanged
from the previous state.
Sakari Ailus (3):
Revert "staging: imgu: Address a compiler warning on alignment"
staging: ipu3-imgu: Move alignment attribute to field
staging: ipu3-imgu: Add a sanity check for the parameter struct size
drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++---
drivers/staging/media/ipu3/ipu3-css.c | 7 +++++++
2 files changed, 11 insertions(+), 3 deletions(-)
--
2.20.1
next reply other threads:[~2020-04-16 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 9:18 Sakari Ailus [this message]
2020-04-16 9:18 ` [PATCH 1/3] Revert "staging: imgu: Address a compiler warning on alignment" Sakari Ailus
2020-04-27 15:39 ` [PATCH v1.1 " Sakari Ailus
2020-04-16 9:18 ` [PATCH 2/3] staging: ipu3-imgu: Move alignment attribute to field Sakari Ailus
2020-04-16 9:18 ` [PATCH 3/3] staging: ipu3-imgu: Add a sanity check for the parameter struct size Sakari Ailus
2020-04-26 2:42 ` [PATCH 0/3] IPU3 ImgU driver parameter struct fixes Bingbu Cao
2020-04-27 15:43 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416091850.31177-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.