Re: [PATCH 0/3] IPU3 ImgU driver parameter struct fixes

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Tested-by: Bingbu Cao <bingbu.cao@intel.com>

On 4/16/20 5:18 PM, Sakari Ailus wrote:
> Hi all,
> 
> This set addresses parameter struct memory layout changes introduced by
> seemingly innocent patches, and adds a sanity check for the struct size to
> avoid this from happening again. This only touches the uAPI, not the
> ipu3-abi.h that deals with ABI not visible in the driver uAPI. That should
> be addressed as well going forward.
> 
> The first patch does not probably entirely fix the issues, but with the
> second patch added, pahole agrees the struct memory layout is unchanged
> from the previous state.
> 
> Sakari Ailus (3):
>   Revert "staging: imgu: Address a compiler warning on alignment"
>   staging: ipu3-imgu: Move alignment attribute to field
>   staging: ipu3-imgu: Add a sanity check for the parameter struct size
> 
>  drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++---
>  drivers/staging/media/ipu3/ipu3-css.c           | 7 +++++++
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 

-- 
Best regards,
Bingbu Cao