All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line
Date: Fri, 17 Apr 2020 09:58:52 +0200	[thread overview]
Message-ID: <20200417075852.GA20049@lst.de> (raw)
In-Reply-To: <5139e8e1-6389-3387-dc39-6983b08ff28d@ozlabs.ru>

On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashevskiy wrote:
> And the fact they were exported leaves possibility that there is a
> driver somewhere relying on these symbols or distro kernel won't build
> because the symbol disappeared from exports (I do not know what KABI
> guarantees or if mainline kernel cares).

We absolutely do not care.  In fact for abuses of APIs that drivers
should not use we almost care to make them private and break people
abusing them.

> I do not care in particular but
> some might, a line separated with empty lines in the commit log would do.

I'll add a blurb for the next version.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
	Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line
Date: Fri, 17 Apr 2020 09:58:52 +0200	[thread overview]
Message-ID: <20200417075852.GA20049@lst.de> (raw)
In-Reply-To: <5139e8e1-6389-3387-dc39-6983b08ff28d@ozlabs.ru>

On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashevskiy wrote:
> And the fact they were exported leaves possibility that there is a
> driver somewhere relying on these symbols or distro kernel won't build
> because the symbol disappeared from exports (I do not know what KABI
> guarantees or if mainline kernel cares).

We absolutely do not care.  In fact for abuses of APIs that drivers
should not use we almost care to make them private and break people
abusing them.

> I do not care in particular but
> some might, a line separated with empty lines in the commit log would do.

I'll add a blurb for the next version.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Christoph Hellwig <hch@lst.de>,
	iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line
Date: Fri, 17 Apr 2020 09:58:52 +0200	[thread overview]
Message-ID: <20200417075852.GA20049@lst.de> (raw)
In-Reply-To: <5139e8e1-6389-3387-dc39-6983b08ff28d@ozlabs.ru>

On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashevskiy wrote:
> And the fact they were exported leaves possibility that there is a
> driver somewhere relying on these symbols or distro kernel won't build
> because the symbol disappeared from exports (I do not know what KABI
> guarantees or if mainline kernel cares).

We absolutely do not care.  In fact for abuses of APIs that drivers
should not use we almost care to make them private and break people
abusing them.

> I do not care in particular but
> some might, a line separated with empty lines in the commit log would do.

I'll add a blurb for the next version.

  reply	other threads:[~2020-04-17  7:59 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 12:25 generic DMA bypass flag v3 Christoph Hellwig
2020-04-14 12:25 ` Christoph Hellwig
2020-04-14 12:25 ` Christoph Hellwig
2020-04-14 12:25 ` [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-15  2:26   ` Alexey Kardashevskiy
2020-04-15  2:26     ` Alexey Kardashevskiy
2020-04-15  2:26     ` Alexey Kardashevskiy
2020-04-15  6:18     ` Christoph Hellwig
2020-04-15  6:18       ` Christoph Hellwig
2020-04-15  6:18       ` Christoph Hellwig
2020-04-15 11:21       ` Alexey Kardashevskiy
2020-04-15 11:21         ` Alexey Kardashevskiy
2020-04-15 11:21         ` Alexey Kardashevskiy
2020-04-17  7:58         ` Christoph Hellwig [this message]
2020-04-17  7:58           ` Christoph Hellwig
2020-04-17  7:58           ` Christoph Hellwig
2020-05-05  4:18           ` Alexey Kardashevskiy
2020-05-05  4:18             ` Alexey Kardashevskiy
2020-05-05  4:18             ` Alexey Kardashevskiy
2020-05-09  8:19             ` Christoph Hellwig
2020-05-09  8:19               ` Christoph Hellwig
2020-05-09  8:19               ` Christoph Hellwig
2020-05-09 14:07               ` Alexey Kardashevskiy
2020-05-09 14:07                 ` Alexey Kardashevskiy
2020-05-09 14:07                 ` Alexey Kardashevskiy
2020-06-03  4:13               ` Alexey Kardashevskiy
2020-06-03  4:13                 ` Alexey Kardashevskiy
2020-06-03  4:13                 ` Alexey Kardashevskiy
2020-07-07  0:43                 ` Alexey Kardashevskiy
2020-07-07  0:43                   ` Alexey Kardashevskiy
2020-07-07  0:43                   ` Alexey Kardashevskiy
2020-07-07 14:51                   ` Christoph Hellwig
2020-07-07 14:51                     ` Christoph Hellwig
2020-07-07 14:51                     ` Christoph Hellwig
2020-04-14 12:25 ` [PATCH 2/4] dma-mapping: inline the fast path dma-direct calls Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:25 ` [PATCH 3/4] dma-mapping: add a dma_ops_bypass flag to struct device Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:47   ` Greg Kroah-Hartman
2020-04-14 12:47     ` Greg Kroah-Hartman
2020-04-14 12:47     ` Greg Kroah-Hartman
2020-04-18 12:42   ` Joerg Roedel
2020-04-18 12:42     ` Joerg Roedel
2020-04-18 12:42     ` Joerg Roedel
2020-04-19  8:00     ` Christoph Hellwig
2020-04-19  8:00       ` Christoph Hellwig
2020-04-19  8:00       ` Christoph Hellwig
2020-04-19 12:25       ` Joerg Roedel
2020-04-19 12:25         ` Joerg Roedel
2020-04-19 12:25         ` Joerg Roedel
2020-04-19 14:46         ` Alexey Kardashevskiy
2020-04-19 14:46           ` Alexey Kardashevskiy
2020-04-19 14:46           ` Alexey Kardashevskiy
2020-04-14 12:25 ` [PATCH 4/4] powerpc: use the generic dma_ops_bypass mode Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig
2020-04-14 12:25   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417075852.GA20049@lst.de \
    --to=hch@lst.de \
    --cc=aik@ozlabs.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.