Re: [PATCH 1/3] media: cec: don't select PCI & DMI

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Fri, 17 Apr 2020 09:30:51 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Hi Mauro,
> 
> On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> > While select would be a great idea for most archs, this
> > causes a breakage with s390:
> >
> >         "I don't think that's a good idea, as it suddenly enables selecting all PCI
> >          drivers on platforms that do not have PCI.
> >
> >             WARNING: unmet direct dependencies detected for PCI
> >               Depends on [n]: HAVE_PCI [=n]
> >               Selected by [m]:
> >               - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>  
> 
> Thanks for your patch!
> 
> Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
> separate directory")
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Btw, I almost solved it on a different way, keeping the select and making
it depends on HAVE_PCI.

I ended by opting to do this change in order to try to avoid more
Kconfig noise (and because "select PCI" is not popular those days).

Thanks,
Mauro