All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"H. Peter Anvin" <hpa@zytor.com>, "Jann Horn" <jannh@google.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org, "Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Josh Poimboeuf" <jpoimboe@redhat.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	mhiramat@kernel.org
Subject: Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection
Date: Fri, 17 Apr 2020 23:56:01 +0200	[thread overview]
Message-ID: <20200417215601.GQ2483@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20200417202728.w2v3frkxqsgutb7h@outlook.office365.com>

On Fri, Apr 17, 2020 at 04:27:28PM -0400, Rodrigo Siqueira wrote:
> I'm going to work on the FPU issues in the display code. In this sense,
> could you clarify a little bit more about the Makefile issues?

I think it might have been PEBKAC, I assumed allmodconfig would end up
selecting the driver, it doesn't!

Adding "AMD GPU" to a defconfig seems to make it work:

$ make O=defconfig-build/ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o

Sorry about the confusion.

> Also, I applied the patch `[PATCH v4] x86: insn: Add insn_is_fpu()` and
> tried to reproduce the warning that you described but I didn't see it.
> Could you explain to me how I can check those warnings?

grab:

  git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/fpu

Then build like above:

$ make O=defconfig-build/ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o

And manually validate:

$ defconfig-build/tools/objtool/objtool check -Ffa defconfig-build/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o
defconfig-build/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o: warning: objtool: dcn_validate_bandwidth()+0x1b17: FPU instruction outside of kernel_fpu_{begin,end}()


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"Josh Poimboeuf" <jpoimboe@redhat.com>,
	"Jann Horn" <jannh@google.com>, "Leo Li" <sunpeng.li@amd.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org, "Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Andy Lutomirski" <luto@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Harry Wentland" <harry.wentland@amd.com>,
	mhiramat@kernel.org
Subject: Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection
Date: Fri, 17 Apr 2020 23:56:01 +0200	[thread overview]
Message-ID: <20200417215601.GQ2483@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20200417202728.w2v3frkxqsgutb7h@outlook.office365.com>

On Fri, Apr 17, 2020 at 04:27:28PM -0400, Rodrigo Siqueira wrote:
> I'm going to work on the FPU issues in the display code. In this sense,
> could you clarify a little bit more about the Makefile issues?

I think it might have been PEBKAC, I assumed allmodconfig would end up
selecting the driver, it doesn't!

Adding "AMD GPU" to a defconfig seems to make it work:

$ make O=defconfig-build/ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o

Sorry about the confusion.

> Also, I applied the patch `[PATCH v4] x86: insn: Add insn_is_fpu()` and
> tried to reproduce the warning that you described but I didn't see it.
> Could you explain to me how I can check those warnings?

grab:

  git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/fpu

Then build like above:

$ make O=defconfig-build/ drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o

And manually validate:

$ defconfig-build/tools/objtool/objtool check -Ffa defconfig-build/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o
defconfig-build/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o: warning: objtool: dcn_validate_bandwidth()+0x1b17: FPU instruction outside of kernel_fpu_{begin,end}()



  reply	other threads:[~2020-04-18  9:27 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  2:34 AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection Jann Horn
2020-04-02  2:34 ` Jann Horn
2020-04-02  7:33 ` Christian König
2020-04-02  7:33   ` Christian König
2020-04-02  7:56   ` Jann Horn
2020-04-02  7:56     ` Jann Horn
2020-04-02  9:36     ` Thomas Gleixner
2020-04-02  9:36       ` Thomas Gleixner
2020-04-02 14:50       ` Jann Horn
2020-04-02 14:50         ` Jann Horn
2020-04-02 14:13   ` Peter Zijlstra
2020-04-02 14:13     ` Peter Zijlstra
2020-04-03  5:28     ` Masami Hiramatsu
2020-04-03  5:28       ` Masami Hiramatsu
2020-04-03 11:21       ` Peter Zijlstra
2020-04-03 11:21         ` Peter Zijlstra
2020-04-04  3:08         ` Masami Hiramatsu
2020-04-04  3:08           ` Masami Hiramatsu
2020-04-04  3:15           ` Randy Dunlap
2020-04-04  3:15             ` Randy Dunlap
2020-04-04  8:32             ` Masami Hiramatsu
2020-04-04  8:32               ` Masami Hiramatsu
2020-04-04 14:32           ` Peter Zijlstra
2020-04-04 14:32             ` Peter Zijlstra
2020-04-05  3:19             ` Masami Hiramatsu
2020-04-05  3:19               ` Masami Hiramatsu
2020-04-06 10:21               ` Peter Zijlstra
2020-04-06 10:21                 ` Peter Zijlstra
2020-04-07  9:50                 ` Masami Hiramatsu
2020-04-07  9:50                   ` Masami Hiramatsu
2020-04-07 11:15                   ` Peter Zijlstra
2020-04-07 11:15                     ` Peter Zijlstra
2020-04-07 15:41                     ` Masami Hiramatsu
2020-04-07 15:41                       ` Masami Hiramatsu
2020-04-07 15:43                       ` [PATCH] x86: insn: Add insn_is_fpu() Masami Hiramatsu
2020-04-07 15:43                         ` Masami Hiramatsu
2020-04-07 15:54                       ` AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection Peter Zijlstra
2020-04-07 15:54                         ` Peter Zijlstra
2020-04-08  0:31                         ` Masami Hiramatsu
2020-04-08  0:31                           ` Masami Hiramatsu
2020-04-08 16:09                         ` [PATCH v2] x86: insn: Add insn_is_fpu() Masami Hiramatsu
2020-04-08 16:09                           ` Masami Hiramatsu
2020-04-09 14:32                           ` Peter Zijlstra
2020-04-09 14:32                             ` Peter Zijlstra
2020-04-09 14:45                             ` Peter Zijlstra
2020-04-09 14:45                               ` Peter Zijlstra
2020-04-10  0:47                             ` Masami Hiramatsu
2020-04-10  0:47                               ` Masami Hiramatsu
2020-04-10  1:22                             ` [PATCH v3] " Masami Hiramatsu
2020-04-10  1:22                               ` Masami Hiramatsu
2020-04-15  8:23                               ` Masami Hiramatsu
2020-04-15  8:23                                 ` Masami Hiramatsu
2020-04-15  8:49                             ` [PATCH v4] " Masami Hiramatsu
2020-04-15  8:49                               ` Masami Hiramatsu
2020-04-04 14:36           ` AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection Peter Zijlstra
2020-04-04 14:36             ` Peter Zijlstra
2020-04-05  3:37             ` Masami Hiramatsu
2020-04-05  3:37               ` Masami Hiramatsu
2020-04-09 15:59     ` Peter Zijlstra
2020-04-09 15:59       ` Peter Zijlstra
2020-04-09 17:09       ` Peter Zijlstra
2020-04-09 17:09         ` Peter Zijlstra
2020-04-09 18:15         ` Christian König
2020-04-09 18:15           ` Christian König
2020-04-09 20:01           ` Peter Zijlstra
2020-04-09 20:01             ` Peter Zijlstra
2020-04-10 14:31             ` Christian König
2020-04-10 14:31               ` Christian König
2020-04-15  9:16               ` Peter Zijlstra
2020-04-15  9:16                 ` Peter Zijlstra
2020-04-17 20:27             ` Rodrigo Siqueira
2020-04-17 20:27               ` Rodrigo Siqueira
2020-04-17 21:56               ` Peter Zijlstra [this message]
2020-04-17 21:56                 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417215601.GQ2483@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=David1.Zhou@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=acme@kernel.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bp@alien8.de \
    --cc=christian.koenig@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=sunpeng.li@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.