All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	agross@kernel.org, robdclark@gmail.com,
	linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/qcom:fix local_base status check
Date: Sat, 18 Apr 2020 13:54:00 +0200	[thread overview]
Message-ID: <20200418115400.GF21900@8bytes.org> (raw)
In-Reply-To: <7a565c74-f223-83da-cf32-0474be6c9460@cmss.chinamobile.com>

On Thu, Apr 16, 2020 at 02:42:23PM +0800, Tang Bin wrote:
>         The function qcom_iommu_device_probe() does not perform sufficient
> error checking after executing devm_ioremap_resource(), which can result in
> crashes if a critical error path is encountered.
> 
> Fixes: 0ae349a0("iommu/qcom: Add qcom_iommu")

Yes, that sounds better. Please use it for the commit message and also
add the Fixes line and resubmit the fix to me.
Please make the fixes line:

	Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu")

So that the commit-id is 12 characters long and a space between it and
the subject.

Thanks,

	Joerg


WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, agross@kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] iommu/qcom:fix local_base status check
Date: Sat, 18 Apr 2020 13:54:00 +0200	[thread overview]
Message-ID: <20200418115400.GF21900@8bytes.org> (raw)
In-Reply-To: <7a565c74-f223-83da-cf32-0474be6c9460@cmss.chinamobile.com>

On Thu, Apr 16, 2020 at 02:42:23PM +0800, Tang Bin wrote:
>         The function qcom_iommu_device_probe() does not perform sufficient
> error checking after executing devm_ioremap_resource(), which can result in
> crashes if a critical error path is encountered.
> 
> Fixes: 0ae349a0("iommu/qcom: Add qcom_iommu")

Yes, that sounds better. Please use it for the commit message and also
add the Fixes line and resubmit the fix to me.
Please make the fixes line:

	Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu")

So that the commit-id is 12 characters long and a space between it and
the subject.

Thanks,

	Joerg

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-04-18 11:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  6:33 [PATCH] iommu/qcom:fix local_base status check Tang Bin
2020-04-02  6:33 ` Tang Bin
2020-04-02  6:45 ` Bjorn Andersson
2020-04-02  6:45   ` Bjorn Andersson
2020-04-08 11:27   ` Tang Bin
2020-04-16  6:42   ` Tang Bin
2020-04-16  6:42     ` Tang Bin
2020-04-18 11:54     ` Joerg Roedel [this message]
2020-04-18 11:54       ` Joerg Roedel
2020-04-18 13:08       ` Tang Bin
2020-04-18 13:08         ` Tang Bin
2020-04-16 10:05 ` Robin Murphy
2020-04-16 10:05   ` Robin Murphy
2020-04-16 10:12   ` Tang Bin
2020-04-16 10:12     ` Tang Bin
  -- strict thread matches above, loose matches on Subject: below --
2020-04-01 15:20 Tang Bin
2020-04-01 23:36 ` kbuild test robot
2020-04-01 23:36 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200418115400.GF21900@8bytes.org \
    --to=joro@8bytes.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=tangbin@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.