* [bug report] media: cec-gpio: add HDMI CEC GPIO driver
@ 2020-04-18 17:16 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2020-04-18 17:16 UTC (permalink / raw)
To: hans.verkuil; +Cc: linux-media
Hello Hans Verkuil,
The patch 1e33936d3bae: "media: cec-gpio: add HDMI CEC GPIO driver"
from Jun 28, 2017, leads to the following static checker warning:
drivers/media/cec/platform/cec-gpio/cec-gpio.c:40 cec_gpio_read()
warn: signedness bug returning '(-4095)'
drivers/media/cec/platform/cec-gpio/cec-gpio.c
34 static bool cec_gpio_read(struct cec_adapter *adap)
35 {
36 struct cec_gpio *cec = cec_get_drvdata(adap);
37
38 if (cec->cec_is_low)
39 return false;
40 return gpiod_get_value(cec->cec_gpio);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
negative error codes become "true".
41 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-18 17:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-18 17:16 [bug report] media: cec-gpio: add HDMI CEC GPIO driver Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.