[Buildroot] [PATCH 1/1] package/python-coherence: select pyasn1 instead of pyasn

[Buildroot] [PATCH 1/1] package/python-coherence: select pyasn1 instead of pyasn

[James Hilliard]

The python-pyasn package is an outdated version of python-pyasn1 and
should not be used.

We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1
does not depend on it.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/python-coherence/Config.in | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/package/python-coherence/Config.in b/package/python-coherence/Config.in
index 63427964a7..0f50080e67 100644
--- a/package/python-coherence/Config.in
+++ b/package/python-coherence/Config.in
@@ -1,15 +1,10 @@
 config BR2_PACKAGE_PYTHON_COHERENCE
 	bool "python-coherence"
 	depends on BR2_PACKAGE_PYTHON
-	depends on BR2_INSTALL_LIBSTDCPP # python-pyasn
 	select BR2_PACKAGE_PYTHON_TWISTED
 	select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE
-	select BR2_PACKAGE_PYTHON_PYASN
+	select BR2_PACKAGE_PYTHON_PYASN1
 	help
 	  A DLNA/UPnP Media Server and Framework for the Digital Living.
 
 	  https://github.com/coherence-project/Coherence
-
-comment "python-coherence needs a toolchain w/ C++"
-	depends on BR2_PACKAGE_PYTHON
-	depends on !BR2_INSTALL_LIBSTDCPP
-- 
2.20.1

[Buildroot] [PATCH 1/1] package/python-coherence: select pyasn1 instead of pyasn

[Thomas Petazzoni]

On Mon, 13 Apr 2020 17:17:04 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> The python-pyasn package is an outdated version of python-pyasn1 and
> should not be used.
> 
> We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1
> does not depend on it.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-coherence/Config.in | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Applied to master, thanks. I assume your plan is to get rid of
python-pyasn and python-pyasn-modules now?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/python-coherence: select pyasn1 instead of pyasn

[James Hilliard]

On Sun, Apr 19, 2020 at 2:18 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 13 Apr 2020 17:17:04 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > The python-pyasn package is an outdated version of python-pyasn1 and
> > should not be used.
> >
> > We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1
> > does not depend on it.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >  package/python-coherence/Config.in | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
>
> Applied to master, thanks. I assume your plan is to get rid of
> python-pyasn and python-pyasn-modules now?
Yep, was just waiting on these to be merged first.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[Buildroot] [PATCH 1/1] package/python-coherence: select pyasn1 instead of pyasn

[Thomas Petazzoni]

On Sun, 19 Apr 2020 02:21:30 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> > Applied to master, thanks. I assume your plan is to get rid of
> > python-pyasn and python-pyasn-modules now?  
> Yep, was just waiting on these to be merged first.

In this sort of situation, you can also send a series of patches. The
fact that they are sent as as series makes it clear that they have a
dependency.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com