Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

From: kbuild test robot <lkp@intel.com>
To: "Hadar Gat" <hadar.gat@arm.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
	"Jose Abreu" <joabreu@synopsys.com>, "JC Kuo" <jckuo@nvidia.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Stefan Agner" <stefan@agner.ch>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Frank Rowand" <frowand.list@gmail.com>,
	linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mtd@lists.infradead.org, sparclinux@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Ofir Drang" <ofir.drang@arm.com>,
	"Gilad Ben-Yossef" <gilad@benyossef.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	freedreno@lists.freedesktop.org
Cc: linux-samsung-soc@vger.kernel.org, kbuild-all@lists.01.org,
	linux-iio@vger.kernel.org, netdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-mtd@lists.infradead.org, Hadar Gat <hadar.gat@arm.com>,
	sparclinux@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
Date: Mon, 20 Apr 2020 14:37:57 +0800	[thread overview]
Message-ID: <202004201451.wWAcAcjA%lkp@intel.com> (raw)
In-Reply-To: <1587030553-5990-1-git-send-email-hadar.gat@arm.com>

[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]

Hi Hadar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
     385 |  vdoa_pdev = of_find_device_by_node(vdoa_node);
         |              ^~~~~~~~~~~~~~~~~~~~~~
         |              of_find_spi_device_by_node
   drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     385 |  vdoa_pdev = of_find_device_by_node(vdoa_node);
         |            ^
   cc1: some warnings being treated as errors

vim +385 drivers/media/platform/coda/coda-common.c

927933f7b4b213 drivers/media/platform/coda.c             Philipp Zabel   2013-09-30  374  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  375  static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  376  {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  377  	struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  378  	struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  379  	struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  380  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  381  	vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  382  	if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  383  		return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  384  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385  	vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  386  	if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  387  		goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  388  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  389  	vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  390  	if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  391  		vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  392  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  393  out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  394  	of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  395  
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  396  	return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  397  }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20  398  

:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format

:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]

[-- Attachment #3: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu