From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Clay McClure <clay@daemons.net>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Sekhar Nori <nsekhar@ti.com>, Networking <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: cpts: Condition WARN_ON on PTP_1588_CLOCK
Date: Mon, 20 Apr 2020 10:00:51 -0700 [thread overview]
Message-ID: <20200420170051.GB11862@localhost> (raw)
In-Reply-To: <CAK8P3a36ZxNJxUS4UzrwJiMx8UrgYPkcv4X6yYw7EC4jRBbbGQ@mail.gmail.com>
On Mon, Apr 20, 2020 at 04:38:32PM +0200, Arnd Bergmann wrote:
>
> I suspect we should move all of them back. This was an early user
> of 'imply', but the meaning of that keyword has now changed
> in the latest Kconfig.
Can you please explain the justification for changing the meaning?
It was a big PITA for me to support this in the first place, and now
we are back to square one?
> Something else is wrong if you need IS_ERR_OR_NULL(). Any
> kernel interface should either return an negative error code when
> something goes wrong, or should return NULL for all errors, but
> not mix the two.
On the contrary, this is exactly what the whole "imply" thing
demanded.
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 172) #if IS_REACHABLE(CONFIG_PTP_1588_CLOCK)
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 173)
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 174) /**
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 175) * ptp_clock_register() - register a PTP hardware clock driver
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 176) *
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 177) * @info: Structure describing the new clock.
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 178) * @parent: Pointer to the parent device of the new clock.
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 179) *
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 180) * Returns a valid pointer on success or PTR_ERR on failure. If PHC
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 181) * support is missing at the configuration level, this function
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 182) * returns NULL, and drivers are expected to gracefully handle that
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 183) * case separately.
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 184) */
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 185)
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 186) extern struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
d1cbfd771ce82 (Nicolas Pitre 2016-11-11 187) struct device *parent);
Thanks,
Richard
next prev parent reply other threads:[~2020-04-20 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 8:56 [PATCH] net: cpts: Condition WARN_ON on PTP_1588_CLOCK Clay McClure
2020-04-16 11:11 ` Grygorii Strashko
2020-04-20 9:36 ` Clay McClure
2020-04-20 14:38 ` Arnd Bergmann
2020-04-20 17:00 ` Richard Cochran [this message]
2020-04-20 18:57 ` Arnd Bergmann
2020-04-20 21:18 ` Richard Cochran
2020-04-20 21:21 ` Arnd Bergmann
2020-04-20 21:34 ` Richard Cochran
2020-04-20 21:42 ` Arnd Bergmann
2020-04-22 11:16 ` Grygorii Strashko
2020-04-26 2:41 ` Clay McClure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420170051.GB11862@localhost \
--to=richardcochran@gmail.com \
--cc=arnd@arndb.de \
--cc=clay@daemons.net \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.