From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Clay McClure <clay@daemons.net>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Sekhar Nori <nsekhar@ti.com>, Networking <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: cpts: Condition WARN_ON on PTP_1588_CLOCK
Date: Mon, 20 Apr 2020 14:34:06 -0700 [thread overview]
Message-ID: <20200420213406.GB20996@localhost> (raw)
In-Reply-To: <CAK8P3a18540y3zqR=mqKhj-goinN3c-FGKvAnTHnLgBxiPa4mA@mail.gmail.com>
On Mon, Apr 20, 2020 at 11:21:20PM +0200, Arnd Bergmann wrote:
> It's not great, but we have other interfaces like this that can return NULL for
> success when the subsystem is disabled. The problem is when there is
> a mismatch between the caller treating NULL as failure when it is meant to
> be "successful lack of object returned".
Yeah, that should be fixed.
To be clear, do you all see a need to change the stubbed version of
ptp_clock_register() or not?
Thanks,
Richard
next prev parent reply other threads:[~2020-04-20 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 8:56 [PATCH] net: cpts: Condition WARN_ON on PTP_1588_CLOCK Clay McClure
2020-04-16 11:11 ` Grygorii Strashko
2020-04-20 9:36 ` Clay McClure
2020-04-20 14:38 ` Arnd Bergmann
2020-04-20 17:00 ` Richard Cochran
2020-04-20 18:57 ` Arnd Bergmann
2020-04-20 21:18 ` Richard Cochran
2020-04-20 21:21 ` Arnd Bergmann
2020-04-20 21:34 ` Richard Cochran [this message]
2020-04-20 21:42 ` Arnd Bergmann
2020-04-22 11:16 ` Grygorii Strashko
2020-04-26 2:41 ` Clay McClure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420213406.GB20996@localhost \
--to=richardcochran@gmail.com \
--cc=arnd@arndb.de \
--cc=clay@daemons.net \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.